tobast/glowingbear-mainbox
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

Don't fail failed tests by accessing undefined members

Browse source 
If a plugin didn't recognize something it should have recognized, don't fail in
checking whether it failed.

Also, semicolons.
This commit is contained in:
Lorenz Hübschle-Schneider 2014-08-09 13:54:18 +01:00 • committed by David Cormier
parent f2bfb3444e
commit 230e33136c
1 changed files with 8 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
test/unit/plugins.js
View file

@ -1,12 +1,15 @@
/* plugins go here */ /* plugins go here */
var msg = function(msg) { var msg = function(msg) {
return {'text': msg } return {'text': msg };
} };
var metadata_name = function(message) { var metadata_name = function(message) {
return message['metadata'][0]['name'] if (message.metadata && message.metadata[0] && message.metadata[0].name) {
} return message.metadata[0].name;
}
return null;
};
var expectTheseMessagesToContain = function(urls, pluginType, plugins) { var expectTheseMessagesToContain = function(urls, pluginType, plugins) {
for (var i = 0; i < urls.length; i++) { for (var i = 0; i < urls.length; i++) {
@ -16,7 +19,7 @@ var expectTheseMessagesToContain = function(urls, pluginType, plugins) {
) )
).toEqual(pluginType); ).toEqual(pluginType);
} }
} };
describe('filter', function() { describe('filter', function() {
beforeEach(module('plugins')); beforeEach(module('plugins'));