From 230e33136c6434292e7c5ca56c49fe55236f14cc Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Lorenz=20H=C3=BCbschle-Schneider?= Date: Sat, 9 Aug 2014 13:54:18 +0100 Subject: [PATCH] Don't fail failed tests by accessing undefined members If a plugin didn't recognize something it should have recognized, don't fail in checking whether it failed. Also, semicolons. --- test/unit/plugins.js | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/test/unit/plugins.js b/test/unit/plugins.js index c7533dc..9ca41d0 100644 --- a/test/unit/plugins.js +++ b/test/unit/plugins.js @@ -1,12 +1,15 @@ /* plugins go here */ var msg = function(msg) { - return {'text': msg } -} + return {'text': msg }; +}; var metadata_name = function(message) { - return message['metadata'][0]['name'] -} + if (message.metadata && message.metadata[0] && message.metadata[0].name) { + return message.metadata[0].name; + } + return null; +}; var expectTheseMessagesToContain = function(urls, pluginType, plugins) { for (var i = 0; i < urls.length; i++) { @@ -16,7 +19,7 @@ var expectTheseMessagesToContain = function(urls, pluginType, plugins) { ) ).toEqual(pluginType); } -} +}; describe('filter', function() { beforeEach(module('plugins'));