a527428763
There is a bug in WeeChat when hdata is null, which happens when the hotlist is empty (meaning all buffers are read). Our websocket callback machinery expects every command with id to return data, so this code in current versions of WeeChat will lead to a slow leak. But I think lots of things in our code will do this already so I'm not entirely sure it's too problematic to let this patch go by. We could use infolists instead of hdata, but that is cumbersome to parse and less performant for WeeChat, and sends more data over the wire. I propose we make a separate attempt at cleaning up the callbacks. Since we store time on them we could have a cleanuptask that looks through them and deletes old callbacks. Maybe @dcormier could have a look? |
||
---|---|---|
.. | ||
connection.js | ||
file-change.js | ||
filters.js | ||
glowingbear.js | ||
handlers.js | ||
imgur-drop-directive.js | ||
imgur.js | ||
inputbar.js | ||
irc-utils.js | ||
localstorage.js | ||
models.js | ||
notifications.js | ||
plugin-directive.js | ||
plugins.js | ||
settings.js | ||
utils.js | ||
websockets.js | ||
weechat.js | ||
whenscrolled-directive.js |