David Cormier
2599edec5a
Format README titles appropriately
2014-08-27 12:36:34 -04:00
Lorenz Hübschle-Schneider
33d43ee28d
Add minification
2014-08-27 17:30:16 +01:00
Lorenz Hübschle-Schneider
69e1e1907d
Use strict angular dependency injection
...
Prerequisite for proper minification
2014-08-27 17:28:01 +01:00
Lorenz Hübschle-Schneider
aef707a12f
Merge pull request #424 from glowing-bear/add-e2e-tests
...
Setup testing
2014-08-27 17:23:57 +01:00
David Cormier
06b1db8c9d
Merge pull request #399 from glowing-bear/fix-keypress
...
Handle keypress events as well
2014-08-26 20:23:58 -04:00
David Cormier
9675909ab5
Add sample E2E test
2014-08-26 20:17:22 -04:00
David Cormier
f1d36c1f96
Setup end to end testing
...
Add necessary targets in the package.json file
and update test instructions
2014-08-26 20:17:22 -04:00
Lorenz Hübschle-Schneider
92282e3a93
Test images with GET parameters as well ( #414 )
2014-08-26 20:17:22 -04:00
Lorenz Hübschle-Schneider
6d36bf1c82
Add tests for Gist & Tweet plugins
2014-08-26 20:17:22 -04:00
Lorenz Hübschle-Schneider
a46df4baab
Use valid test URLs
2014-08-26 20:17:22 -04:00
Lorenz Hübschle-Schneider
230e33136c
Don't fail failed tests by accessing undefined members
...
If a plugin didn't recognize something it should have recognized, don't fail in
checking whether it failed.
Also, semicolons.
2014-08-26 20:17:22 -04:00
Lorenz Hübschle-Schneider
f2bfb3444e
Documentation; make test file executable, jshint tests, add a gitignore
2014-08-26 20:17:22 -04:00
David Cormier
4c3d481447
Add tests for all plugins
2014-08-26 20:17:22 -04:00
David Cormier
b16e9536f0
Make travis run the tests
2014-08-26 20:17:22 -04:00
David Cormier
9da4ece76d
Add instructions on how to run the tests
2014-08-26 20:17:22 -04:00
David Cormier
341fa9f616
Add unit test setup files and sample plugin unit test
2014-08-26 20:17:22 -04:00
David Cormier
583f5b0abe
Add necessary files for unit tests setup
2014-08-26 20:17:22 -04:00
Lorenz Hübschle-Schneider
9501b9f3d3
Fix history keybindings for keypress
...
because ASCII != keydown code in JS m(
2014-08-26 12:44:34 +01:00
Lorenz Hübschle-Schneider
64f412e047
Handle keypress events as well
...
keydown is not enough, because browsers. A (very very very) long
explanation that I read in part is at http://unixpapa.com/js/key.html
E.g. on my keyboard layout (neo2), I don't get a keydown event for alt+<,
which in QWERTY keys is alt + caps lock + u (or the key above shift next to
enter on the right side, which actually isn't present on QWERTY (not ' but to
the right of it - it's not there on a US layout, but it is # on QWERTZ). I do get
a keypress event though.
2014-08-26 12:44:34 +01:00
David Cormier
9e0e3d06ae
Merge pull request #419 from glowing-bear/glyphicon
...
Use "off" glyphicon instead of "remove"
2014-08-25 16:26:17 -04:00
David Cormier
a9f06ee46b
Merge pull request #421 from glowing-bear/double-apply
...
Prevent triggering ng-focus on input during completion
2014-08-25 16:22:21 -04:00
Tor Hveem
5408d77a1b
Merge pull request #422 from glowing-bear/update-angular
...
update angularjs to 1.3 beta 19 to fix bug with quotes around URL
2014-08-25 13:54:29 +02:00
Lorenz Hübschle-Schneider
9c99eefb83
update angularjs to 1.3 beta 19 to fix bug with quotes around URL
2014-08-25 12:40:49 +01:00
Lorenz Hübschle-Schneider
6f1f84aa62
Prevent triggering ng-focus on input during completion
...
$apply during another $apply is not possible, and .focus() on the input node
triggers the ng-focus on it (which hides the sidebar, if on mobile), so to
prevent the exception from being thrown, move the input node focusing
out of the $apply with a timeout of 0.
2014-08-24 18:13:24 +01:00
Lorenz Hübschle-Schneider
611abdf51a
Use "off" glyphicon instead of "remove"
...
Needs a few fixes to not look disproportionately large next to the cog.
Also remove that sodden trailing space.
2014-08-24 17:14:35 +01:00
David Cormier
1c54f0bba0
Merge pull request #400 from glowing-bear/docs
...
Potential improvements to our README
2014-08-24 12:11:38 -04:00
Lorenz Hübschle-Schneider
60e6d0b4b4
Potential improvements to our README
2014-08-24 17:03:52 +01:00
Lorenz Hübschle-Schneider
a6e15fb47a
Delete bindonce mention from README
...
Actually stage the change this time m(
2014-08-24 11:38:53 +01:00
Lorenz Hübschle-Schneider
bb069f8135
Delete bindonce file and mention in README
2014-08-24 11:36:21 +01:00
David Cormier
26a5a03435
Merge pull request #418 from glowing-bear/kill-the-watchers
...
[PLS TEST] Don't watch for changes on existing lines, s/bindonce/angular one-time binding/
2014-08-23 18:18:24 -04:00
David Cormier
da49f2e66b
Merge pull request #414 from glowing-bear/plugin-fixes
...
Image plugin fixes
2014-08-23 15:31:16 -04:00
Lorenz Hübschle-Schneider
4cdf86ed14
Remove bindonce for Angular 1.3 One-Time Bindings
2014-08-23 12:26:04 +01:00
Lorenz Hübschle-Schneider
2cb6b05498
Wrap inlinecolour filter in $sce.trustAsHtml
...
This is required because bo-html is unsafe whereas ng-bind-html requires
"safe" HTML (ng-bind-html-unsafe is deprecated since 1.2)
2014-08-23 12:25:26 +01:00
Lorenz Hübschle-Schneider
d3b8df8bb0
Don't watch for changes on existing lines
...
How did we miss this angular 1.3 feature?
It appears to be a bit similar to bindonce, but also works in ng-repeat!
See https://docs.angularjs.org/guide/expression#one-time-binding
2014-08-23 11:46:05 +01:00
Lorenz Hübschle-Schneider
6fb2d6b364
Merge pull request #411 from torhve/wordbreak
...
Fix word breaking
2014-08-18 08:48:02 -07:00
Lorenz Hübschle-Schneider
b939bc7ca8
Check GET parameters in image embedding
...
This is a great candidate for the tests!
2014-08-18 16:41:30 +01:00
Lorenz Hübschle-Schneider
1235a5e148
Embed Dropbox images
...
We need to pass a parameter, "?dl=1", to get the actual file
2014-08-18 16:37:45 +01:00
Tor Hveem
08847883dd
Merge pull request #409 from glowing-bear/hide-sidebar-onfocus
...
Sidebar focus fixes
2014-08-15 12:43:11 +02:00
Tor Hveem
7baffb15e0
Fix word breaking
...
Use break-all to force breaking in all browsers.
2014-08-14 15:35:40 +02:00
Lorenz Hübschle-Schneider
ae5f0effcf
Auto-close keyboard when opening sidebar (bufferlist)
...
This is for mobile
2014-08-13 09:22:41 +01:00
Lorenz Hübschle-Schneider
e46efba5cf
Update angular version from beta 8 to beta 18
...
ngFocus is broken in beta8
2014-08-13 08:39:56 +01:00
Lorenz Hübschle-Schneider
f7aa7a0871
Hide sidebar when focusing input bar
...
This is for mobile
2014-08-13 08:39:32 +01:00
Tor Hveem
09f94d360e
Merge pull request #398 from glowing-bear/async-plugins
...
Plugin system improvements, Gist & Tweet plugins
2014-08-09 15:31:59 +02:00
Lorenz Hübschle-Schneider
7d13f49dab
Add tweet embedding plugin
2014-08-09 14:18:13 +01:00
Lorenz Hübschle-Schneider
6d988069c7
Add asynchronous GitHub Gist embedding plugin
...
requires a few selectors to be more precise in our CSS
2014-08-09 14:18:13 +01:00
Lorenz Hübschle-Schneider
3d719f3671
Simplify plugins that detect URLs by eliminating redundancy
2014-08-09 14:18:13 +01:00
Lorenz Hübschle-Schneider
703fcb1668
Add support for asynchronous / lazy plugins
...
Fixes #253
2014-08-09 14:18:13 +01:00
Tor Hveem
7ad1974d12
Merge pull request #396 from glowing-bear/default-ssl
...
Default to using SSL if the page is using it as well
2014-08-09 15:13:52 +02:00
Tor Hveem
21cf46d74a
Merge pull request #397 from glowing-bear/accordion-indicators
...
Add indicators to the accordion so people will notice it's actually there
2014-08-09 15:13:06 +02:00
Lorenz Hübschle-Schneider
6f5047fb68
Add indicators to the accordion so people will notice it's actually there
2014-08-07 18:41:18 +01:00
