tobast/glowingbear-mainbox
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity
805 commits 3 branches 0 tags 2.8 MiB
Commit graph

805 commits

This branch
This branch
All branches
Author SHA1 Message Date
Tor Hveem
512f7d726b Merge pull request #282 from glowing-bear/fixonelinebug 
Fix that bug where only one line was loaded
 2014-05-03 16:51:50 +02:00
Lorenz Hübschle-Schneider
9f6f598f40 Merge pull request #281 from glowing-bear/travisbequiet 
Travis: disable build success IRC notifications
 2014-05-03 15:14:31 +01:00
Lorenz Hübschle-Schneider
aab111bb80 Fix that bug where only one line was loaded 
Let me tell the story backwards:
For some reason, only one line would be fetched in `fetchMoreLines`, but
neither `numLines` nor `buffer.requestedLines` were `undefined`. The
paramater `numLines` must have had some strange value, though.
`connection.fetchMoreLines` is invoked through the main controllers
`$scope.fetchMoreLines`, which sets the parameter to `$scope.lines` if it was
undefined before. That value is computed in `$scope.calculateNumLines`,
which takes the height of the lines area and divides it by the height of the first
bufferline. This computation is retriggered on every `resize` event.
The first bufferline is the 'fetch more lines' link at the top of the window. If the
currently active buffer doesn't have more lines, it is hidden with `ngHide`,
causing its `clientHeight` property to be `0`, and the number of lines to be
fetched `$scope.lines = Infinity` (due to a division by zero).
In `connection.fetchMoreLines`, the following request is then made:
`"buffer:0x" + buffer.id + "/own_lines/last_line(-" + numLines + ")/data"`
to which WeeChat responds with one line. Voilà, there's your mess.
 2014-05-03 15:07:12 +01:00
Lorenz Hübschle-Schneider
f3a94eaa6c Travis: disable build success IRC notifications 2014-05-03 14:17:57 +01:00
Lorenz Hübschle-Schneider
36a35628e2 Fix bug where updateNickSpeak would fail on lines without a prefix 2014-05-03 14:12:55 +01:00
Tor Hveem
6812501f12 Merge pull request #278 from glowing-bear/uifix 
Add space to bottom of #bufferlines
 2014-04-30 10:16:49 +02:00
Lorenz Hübschle-Schneider
116e984ac8 Add space to bottom of bufferlines 2014-04-30 09:01:42 +01:00
David Cormier
6e88dfe963 Merge pull request #275 from glowing-bear/countWatchers 
Better countWatchers, remove jQuery uses
 2014-04-29 23:14:02 -04:00
David Cormier
c104385834 css: merge body tags 2014-04-29 21:31:49 -04:00
Tor Hveem
fb2134736c Pixel adjustments to attempt perfectly align icons in top bar 2014-04-29 21:31:49 -04:00
Tor Hveem
dc077ac903 Improve CSS layout. Fix 98% bug that affects chrome/ff differently. 
Conflicts:
	css/glowingbear.css
 2014-04-29 21:31:49 -04:00
Tor Hveem
a2969adf9b Remove old cruft 2014-04-29 21:31:48 -04:00
Lorenz Hübschle-Schneider
d363121556 Remove unnecessary uses of jQuery and dead code 
Native code is faster anyways ;)
 2014-04-28 13:52:21 +01:00
Lorenz Hübschle-Schneider
1d2e5f1d0b Better countWatchers 
The old one missed a few, two on the input and the one in the title.
This version also doesn't use jQuery

From: http://stackoverflow.com/a/18539624 by StackOverflow user "plantian"
 2014-04-28 13:40:27 +01:00
Lorenz Hübschle-Schneider
26d43fa694 Merge pull request #272 from torhve/versionbump 
Bump angular and underscore.js versions
 2014-04-28 13:05:22 +01:00
Tor Hveem
3b74512c77 Bump versions 2014-04-26 22:56:30 +02:00
David Cormier
1480f953c7 Merge pull request #271 from torhve/multiline 
Revert the revertion of multiline and clean it up for new directive.
 2014-04-26 12:54:51 -04:00
David Cormier
49b36bc3ea Merge pull request #270 from glowing-bear/performance3 
Performance improvements (fixed)
 2014-04-26 12:40:29 -04:00
Tor Hveem
20a8289072 Revert the revertion of multiline and clean it up for new directive. 2014-04-26 18:16:46 +02:00
Lorenz Hübschle-Schneider
18d1f4716b Revert "use ng-if to hide date instead of css" 
That actually decreases performance, because it adds a watcher to every line

This reverts commit 16365db588.
 2014-04-26 16:50:04 +01:00
Lorenz Hübschle-Schneider
677ec7783d Reduce usage of ng-show/hide to reduce number of useless DOM elements (fixed) 
Progress in the direction of #87, especially on mobile.
This version doesn't break everything for new users.
 2014-04-26 16:49:56 +01:00
Lorenz Hübschle-Schneider
8cb6fc623e Travis: Reduce IRC notification spam 
Only send a "the build passed" notification if it previously didn't, i.e. the build was fixed.
Failure notifications stay the same
 2014-04-26 16:00:37 +01:00
Lorenz Hübschle-Schneider
16365db588 use ng-if to hide date instead of css 2014-04-26 10:48:19 -04:00
David Cormier
9e57733b31 Merge pull request #268 from glowing-bear/youtube 
Improve youtube matching URL
 2014-04-25 18:41:11 -04:00
Lorenz Hübschle-Schneider
9f46e656cb Improve youtube matching URL 
closes #266
 2014-04-25 18:39:01 -04:00
David Cormier
82cab2c6af Merge pull request #267 from torhve/recentspeaker 
Use recent speaker instead of alphabetical nick tab complete
 2014-04-25 18:35:34 -04:00
David Cormier
696574fa74 Merge pull request #269 from torhve/readme 
Improve the readme
 2014-04-25 15:16:17 -04:00
Lorenz Hübschle-Schneider
f7e1e97b2b Fix a few things in the README 
@torhve, please cherry-pick onto your PR :)
 2014-04-25 21:13:33 +02:00
Tor Hveem
bcc51ef254 Try to improve the readme 2014-04-25 21:13:31 +02:00
Tor Hveem
921e28d0e2 Remove the old and now unused flat nicklist 2014-04-25 21:05:20 +02:00
Tor Hveem
4e08a52f25 Use recent speaker instead of alphabetical nick tab complete 
Use _ for sorting.

Fix jshint problems and naming things.

Fix comments
 2014-04-25 20:33:01 +02:00
Lorenz Hübschle-Schneider
b91241744c Improve youtube matching URL 
closes #266
 2014-04-25 19:03:05 +01:00
David Cormier
253e2ffc60 Revert "Minimise usage of ng-show/hide to reduce number of useless DOM elements" 
This reverts commit b4e1a5aaad.
 2014-04-24 23:20:56 -04:00
David Cormier
fe902fa545 Merge pull request #264 from tribut/new-url 
Update Travis URL
 2014-04-24 11:17:05 -04:00
Felix Eckhofer
39e783083a Update Travis URL 2014-04-24 17:13:15 +02:00
David Cormier
a48a6c58c9 Merge pull request #263 from tribut/new-url 
Update URLs to point to new Github Org
 2014-04-24 11:11:08 -04:00
Felix Eckhofer
482639f7e6 Update URL to point to new Github Org 
Travis-CI url to be updated at a later date?
 2014-04-24 17:08:58 +02:00
David Cormier
0cf8fb315d Merge pull request #249 from lorenzhs/layoutfix 
Don't cut off bottom part of last line in firefox
 2014-04-24 10:23:23 -04:00
David Cormier
aa42027e98 Merge pull request #258 from lorenzhs/performance 
Performance improvements
 2014-04-24 10:18:51 -04:00
David Cormier
d95e85b017 Merge pull request #261 from lorenzhs/nickclickfix 
Improve nick clicking in buffer
 2014-04-24 10:17:36 -04:00
Lorenz Hübschle-Schneider
58f7c9b9be Improve nick clicking in buffer 
* focus input line (stops keyboard from disappearing on mobile)
* add a space after the colon (and detect that in multiple highlight detection)
 2014-04-23 17:19:42 +02:00
David Cormier
8eab74cf61 Merge pull request #260 from lorenzhs/sslerror 
Detect self-signed cert errors
 2014-04-23 08:50:38 -04:00
Lorenz Hübschle-Schneider
e732d72550 Detect self-signed cert errors 2014-04-22 19:04:31 +02:00
Lorenz Hübschle-Schneider
c32ccb8749 Don't cut off bottom part of last line in firefox 
It ignores the padding in the #bufferlines diff. It's still off on small windows, but
a lot better than before. You can't make up the stupid things browsers do.
 2014-04-21 18:31:37 +02:00
Lorenz Hübschle-Schneider
b4e1a5aaad Minimise usage of ng-show/hide to reduce number of useless DOM elements 
Progress in the direction of #87, especially on mobile.
 2014-04-21 18:31:02 +02:00
Lorenz Hübschle-Schneider
3ad76d2ff3 Don't ng-repeat function calls, they're expensive 
See http://tech.small-improvements.com/2013/09/10/angularjs-performance-with-large-lists/
 2014-04-21 18:31:02 +02:00
David Cormier
e7d7f39c95 Merge pull request #250 from lorenzhs/travis 
switch travis to IRC notifications instead of email
 2014-04-21 11:51:19 -04:00
Lorenz Hübschle-Schneider
0f5879502b travis: send a notice, don't join the channel 2014-04-21 17:45:42 +02:00
Lorenz Hübschle-Schneider
7a94d6775d switch travis to IRC notifications instead of email 2014-04-21 17:42:38 +02:00
David Cormier
a1334abb23 Merge pull request #259 from lorenzhs/fetchlinefix 
Fix the one-line-only-bug
 2014-04-20 17:37:09 -04:00