tobast/glowingbear-mainbox
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

weechat-protocol.js: use pointer instead of slicing

Browse source 
I don't know if this changes anything to performance, but my instinct
tells me that it's better to update a pointer within a big array to get
slices than creating a new slice each time.

Perhaps the JS engine is clever enough to not create a copy each time
and only update its internal references of the array bounds, but just
in case...
This commit is contained in:
Philippe Proulx 2013-10-05 15:20:42 -04:00
parent c12f56c614
commit df7d21f63f
1 changed files with 5 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
js/weechat-protocol.js
View file

@ -102,9 +102,9 @@ WeeChatProtocol.prototype = {
return ""; return "";
}, },
_getSlice: function(length) { _getSlice: function(length) {
var slice = this.data.slice(0, length); var slice = this._data.slice(this._dataAt, this._dataAt + length);
this.data = this.data.slice(length); this._dataAt += length;
return slice; return slice;
}, },
@ -148,11 +148,13 @@ WeeChatProtocol.prototype = {
return values; return values;
}, },
_setData: function (data) { _setData: function (data) {
this.data = data; this._data = data;
}, },
parse: function(data) { parse: function(data) {
var self = this; var self = this;
this._setData(data); this._setData(data);
this._dataAt = 0;
var header = this._getHeader(); var header = this._getHeader();
var id = this._getId(); var id = this._getId();