tobast/glowingbear-mainbox
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

Recalculate number of lines needed on resizing

Browse source 
The issue with #bufferlines on mobile has been fixed in 0d580cc, so calculate
the number of (non-wrapping) lines that fit in the window and add a buffer of 10
for hidden lines and to allow scrolling up to fetch more lines (#202)
This commit is contained in:
Lorenz Hübschle-Schneider 2014-02-28 10:23:10 +00:00
parent 9265141bb9
commit a3b52ddddd
1 changed files with 17 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

22
js/glowingbear.js
View file

@ -747,12 +747,24 @@ weechat.controller('WeechatCtrl', ['$rootScope', '$scope', '$store', '$timeout',
// Calculate number of lines to fetch // Calculate number of lines to fetch
$scope.lines = function() { $scope.calculateNumLines = function() {
var lineHeight = document.querySelector(".bufferline").clientHeight; var lineHeight = document.querySelector(".bufferline").clientHeight;
// I would have used document.querySelector("#bufferlines").clientHeight and added 5 to the total result, but that provides incorrect values on mobile var areaHeight = document.querySelector("#bufferlines").clientHeight;
var areaHeight = document.body.clientHeight; // Fetch 10 lines more than theoretically needed so that scrolling up will correctly trigger the loading of more lines
return Math.ceil(areaHeight/lineHeight); // Also, some lines might be hidden, so it's probably better to have a bit of buffer there
}(); var numLines = Math.ceil(areaHeight/lineHeight + 10);
$scope.lines = numLines;
};
$scope.calculateNumLines();
// Recalculate number of lines on resize
window.addEventListener("resize", _.debounce(function() {
// Recalculation fails when not connected
if ($rootScope.connected) {
$scope.calculateNumLines();
}
}, 100));
$rootScope.loadingLines = false; $rootScope.loadingLines = false;
$scope.fetchMoreLines = function() { $scope.fetchMoreLines = function() {