16c00db4bb
Pull AFS fixes from David Howells: "Here's a set of patches that fix a number of bugs in the in-kernel AFS client, including: - Fix directory locking to not use individual page locks for directory reading/scanning but rather to use a semaphore on the afs_vnode struct as the directory contents must be read in a single blob and data from different reads must not be mixed as the entire contents may be shuffled about between reads. - Fix address list parsing to handle port specifiers correctly. - Only give up callback records on a server if we actually talked to that server (we might not be able to access a server). - Fix some callback handling bugs, including refcounting, whole-volume callbacks and when callbacks actually get broken in response to a CB.CallBack op. - Fix some server/address rotation bugs, including giving up if we can't probe a server; giving up if a server says it doesn't have a volume, but there are more servers to try. - Fix the decoding of fetched statuses to be OpenAFS compatible. - Fix the handling of server lookups in Cache Manager ops (such as CB.InitCallBackState3) to use a UUID if possible and to handle no server being found. - Fix a bug in server lookup where not all addresses are compared. - Fix the non-encryption of calls that prevents some servers from being accessed (this also requires an AF_RXRPC patch that has already gone in through the net tree). There's also a patch that adds tracepoints to log Cache Manager ops that don't find a matching server, either by UUID or by address" * tag 'afs-fixes-20180514' of git://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs: afs: Fix the non-encryption of calls afs: Fix CB.CallBack handling afs: Fix whole-volume callback handling afs: Fix afs_find_server search loop afs: Fix the handling of an unfound server in CM operations afs: Add a tracepoint to record callbacks from unlisted servers afs: Fix the handling of CB.InitCallBackState3 to find the server by UUID afs: Fix VNOVOL handling in address rotation afs: Fix AFSFetchStatus decoder to provide OpenAFS compatibility afs: Fix server rotation's handling of fileserver probe failure afs: Fix refcounting in callback registration afs: Fix giving up callbacks on server destruction afs: Fix address list parsing afs: Fix directory page locking
159 lines
2.9 KiB
C
159 lines
2.9 KiB
C
// SPDX-License-Identifier: GPL-2.0
|
|
#include "debug.h"
|
|
#include "util.h"
|
|
#include <linux/kernel.h>
|
|
#include <errno.h>
|
|
|
|
/*
|
|
* Used as the default ->buf value, so that people can always assume
|
|
* buf is non NULL and ->buf is NUL terminated even for a freshly
|
|
* initialized strbuf.
|
|
*/
|
|
char strbuf_slopbuf[1];
|
|
|
|
int strbuf_init(struct strbuf *sb, ssize_t hint)
|
|
{
|
|
sb->alloc = sb->len = 0;
|
|
sb->buf = strbuf_slopbuf;
|
|
if (hint)
|
|
return strbuf_grow(sb, hint);
|
|
return 0;
|
|
}
|
|
|
|
void strbuf_release(struct strbuf *sb)
|
|
{
|
|
if (sb->alloc) {
|
|
zfree(&sb->buf);
|
|
strbuf_init(sb, 0);
|
|
}
|
|
}
|
|
|
|
char *strbuf_detach(struct strbuf *sb, size_t *sz)
|
|
{
|
|
char *res = sb->alloc ? sb->buf : NULL;
|
|
if (sz)
|
|
*sz = sb->len;
|
|
strbuf_init(sb, 0);
|
|
return res;
|
|
}
|
|
|
|
int strbuf_grow(struct strbuf *sb, size_t extra)
|
|
{
|
|
char *buf;
|
|
size_t nr = sb->len + extra + 1;
|
|
|
|
if (nr < sb->alloc)
|
|
return 0;
|
|
|
|
if (nr <= sb->len)
|
|
return -E2BIG;
|
|
|
|
if (alloc_nr(sb->alloc) > nr)
|
|
nr = alloc_nr(sb->alloc);
|
|
|
|
/*
|
|
* Note that sb->buf == strbuf_slopbuf if sb->alloc == 0, and it is
|
|
* a static variable. Thus we have to avoid passing it to realloc.
|
|
*/
|
|
buf = realloc(sb->alloc ? sb->buf : NULL, nr * sizeof(*buf));
|
|
if (!buf)
|
|
return -ENOMEM;
|
|
|
|
sb->buf = buf;
|
|
sb->alloc = nr;
|
|
return 0;
|
|
}
|
|
|
|
int strbuf_addch(struct strbuf *sb, int c)
|
|
{
|
|
int ret = strbuf_grow(sb, 1);
|
|
if (ret)
|
|
return ret;
|
|
|
|
sb->buf[sb->len++] = c;
|
|
sb->buf[sb->len] = '\0';
|
|
return 0;
|
|
}
|
|
|
|
int strbuf_add(struct strbuf *sb, const void *data, size_t len)
|
|
{
|
|
int ret = strbuf_grow(sb, len);
|
|
if (ret)
|
|
return ret;
|
|
|
|
memcpy(sb->buf + sb->len, data, len);
|
|
return strbuf_setlen(sb, sb->len + len);
|
|
}
|
|
|
|
static int strbuf_addv(struct strbuf *sb, const char *fmt, va_list ap)
|
|
{
|
|
int len, ret;
|
|
va_list ap_saved;
|
|
|
|
if (!strbuf_avail(sb)) {
|
|
ret = strbuf_grow(sb, 64);
|
|
if (ret)
|
|
return ret;
|
|
}
|
|
|
|
va_copy(ap_saved, ap);
|
|
len = vsnprintf(sb->buf + sb->len, sb->alloc - sb->len, fmt, ap);
|
|
if (len < 0)
|
|
return len;
|
|
if (len > strbuf_avail(sb)) {
|
|
ret = strbuf_grow(sb, len);
|
|
if (ret)
|
|
return ret;
|
|
len = vsnprintf(sb->buf + sb->len, sb->alloc - sb->len, fmt, ap_saved);
|
|
va_end(ap_saved);
|
|
if (len > strbuf_avail(sb)) {
|
|
pr_debug("this should not happen, your vsnprintf is broken");
|
|
return -EINVAL;
|
|
}
|
|
}
|
|
return strbuf_setlen(sb, sb->len + len);
|
|
}
|
|
|
|
int strbuf_addf(struct strbuf *sb, const char *fmt, ...)
|
|
{
|
|
va_list ap;
|
|
int ret;
|
|
|
|
va_start(ap, fmt);
|
|
ret = strbuf_addv(sb, fmt, ap);
|
|
va_end(ap);
|
|
return ret;
|
|
}
|
|
|
|
ssize_t strbuf_read(struct strbuf *sb, int fd, ssize_t hint)
|
|
{
|
|
size_t oldlen = sb->len;
|
|
size_t oldalloc = sb->alloc;
|
|
int ret;
|
|
|
|
ret = strbuf_grow(sb, hint ? hint : 8192);
|
|
if (ret)
|
|
return ret;
|
|
|
|
for (;;) {
|
|
ssize_t cnt;
|
|
|
|
cnt = read(fd, sb->buf + sb->len, sb->alloc - sb->len - 1);
|
|
if (cnt < 0) {
|
|
if (oldalloc == 0)
|
|
strbuf_release(sb);
|
|
else
|
|
strbuf_setlen(sb, oldlen);
|
|
return cnt;
|
|
}
|
|
if (!cnt)
|
|
break;
|
|
sb->len += cnt;
|
|
ret = strbuf_grow(sb, 8192);
|
|
if (ret)
|
|
return ret;
|
|
}
|
|
|
|
sb->buf[sb->len] = '\0';
|
|
return sb->len - oldlen;
|
|
}
|