16c00db4bb
Pull AFS fixes from David Howells:
"Here's a set of patches that fix a number of bugs in the in-kernel AFS
client, including:
- Fix directory locking to not use individual page locks for
directory reading/scanning but rather to use a semaphore on the
afs_vnode struct as the directory contents must be read in a single
blob and data from different reads must not be mixed as the entire
contents may be shuffled about between reads.
- Fix address list parsing to handle port specifiers correctly.
- Only give up callback records on a server if we actually talked to
that server (we might not be able to access a server).
- Fix some callback handling bugs, including refcounting,
whole-volume callbacks and when callbacks actually get broken in
response to a CB.CallBack op.
- Fix some server/address rotation bugs, including giving up if we
can't probe a server; giving up if a server says it doesn't have a
volume, but there are more servers to try.
- Fix the decoding of fetched statuses to be OpenAFS compatible.
- Fix the handling of server lookups in Cache Manager ops (such as
CB.InitCallBackState3) to use a UUID if possible and to handle no
server being found.
- Fix a bug in server lookup where not all addresses are compared.
- Fix the non-encryption of calls that prevents some servers from
being accessed (this also requires an AF_RXRPC patch that has
already gone in through the net tree).
There's also a patch that adds tracepoints to log Cache Manager ops
that don't find a matching server, either by UUID or by address"
* tag 'afs-fixes-20180514' of git://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs:
afs: Fix the non-encryption of calls
afs: Fix CB.CallBack handling
afs: Fix whole-volume callback handling
afs: Fix afs_find_server search loop
afs: Fix the handling of an unfound server in CM operations
afs: Add a tracepoint to record callbacks from unlisted servers
afs: Fix the handling of CB.InitCallBackState3 to find the server by UUID
afs: Fix VNOVOL handling in address rotation
afs: Fix AFSFetchStatus decoder to provide OpenAFS compatibility
afs: Fix server rotation's handling of fileserver probe failure
afs: Fix refcounting in callback registration
afs: Fix giving up callbacks on server destruction
afs: Fix address list parsing
afs: Fix directory page locking
146 lines
3 KiB
C
146 lines
3 KiB
C
/*
|
|
* Based on intlist.c by:
|
|
* (c) 2009 Arnaldo Carvalho de Melo <acme@redhat.com>
|
|
*
|
|
* Licensed under the GPLv2.
|
|
*/
|
|
|
|
#include <errno.h>
|
|
#include <stdlib.h>
|
|
#include <linux/compiler.h>
|
|
|
|
#include "intlist.h"
|
|
|
|
static struct rb_node *intlist__node_new(struct rblist *rblist __maybe_unused,
|
|
const void *entry)
|
|
{
|
|
int i = (int)((long)entry);
|
|
struct rb_node *rc = NULL;
|
|
struct int_node *node = malloc(sizeof(*node));
|
|
|
|
if (node != NULL) {
|
|
node->i = i;
|
|
node->priv = NULL;
|
|
rc = &node->rb_node;
|
|
}
|
|
|
|
return rc;
|
|
}
|
|
|
|
static void int_node__delete(struct int_node *ilist)
|
|
{
|
|
free(ilist);
|
|
}
|
|
|
|
static void intlist__node_delete(struct rblist *rblist __maybe_unused,
|
|
struct rb_node *rb_node)
|
|
{
|
|
struct int_node *node = container_of(rb_node, struct int_node, rb_node);
|
|
|
|
int_node__delete(node);
|
|
}
|
|
|
|
static int intlist__node_cmp(struct rb_node *rb_node, const void *entry)
|
|
{
|
|
int i = (int)((long)entry);
|
|
struct int_node *node = container_of(rb_node, struct int_node, rb_node);
|
|
|
|
return node->i - i;
|
|
}
|
|
|
|
int intlist__add(struct intlist *ilist, int i)
|
|
{
|
|
return rblist__add_node(&ilist->rblist, (void *)((long)i));
|
|
}
|
|
|
|
void intlist__remove(struct intlist *ilist, struct int_node *node)
|
|
{
|
|
rblist__remove_node(&ilist->rblist, &node->rb_node);
|
|
}
|
|
|
|
static struct int_node *__intlist__findnew(struct intlist *ilist,
|
|
int i, bool create)
|
|
{
|
|
struct int_node *node = NULL;
|
|
struct rb_node *rb_node;
|
|
|
|
if (ilist == NULL)
|
|
return NULL;
|
|
|
|
if (create)
|
|
rb_node = rblist__findnew(&ilist->rblist, (void *)((long)i));
|
|
else
|
|
rb_node = rblist__find(&ilist->rblist, (void *)((long)i));
|
|
|
|
if (rb_node)
|
|
node = container_of(rb_node, struct int_node, rb_node);
|
|
|
|
return node;
|
|
}
|
|
|
|
struct int_node *intlist__find(struct intlist *ilist, int i)
|
|
{
|
|
return __intlist__findnew(ilist, i, false);
|
|
}
|
|
|
|
struct int_node *intlist__findnew(struct intlist *ilist, int i)
|
|
{
|
|
return __intlist__findnew(ilist, i, true);
|
|
}
|
|
|
|
static int intlist__parse_list(struct intlist *ilist, const char *s)
|
|
{
|
|
char *sep;
|
|
int err;
|
|
|
|
do {
|
|
long value = strtol(s, &sep, 10);
|
|
err = -EINVAL;
|
|
if (*sep != ',' && *sep != '\0')
|
|
break;
|
|
err = intlist__add(ilist, value);
|
|
if (err)
|
|
break;
|
|
s = sep + 1;
|
|
} while (*sep != '\0');
|
|
|
|
return err;
|
|
}
|
|
|
|
struct intlist *intlist__new(const char *slist)
|
|
{
|
|
struct intlist *ilist = malloc(sizeof(*ilist));
|
|
|
|
if (ilist != NULL) {
|
|
rblist__init(&ilist->rblist);
|
|
ilist->rblist.node_cmp = intlist__node_cmp;
|
|
ilist->rblist.node_new = intlist__node_new;
|
|
ilist->rblist.node_delete = intlist__node_delete;
|
|
|
|
if (slist && intlist__parse_list(ilist, slist))
|
|
goto out_delete;
|
|
}
|
|
|
|
return ilist;
|
|
out_delete:
|
|
intlist__delete(ilist);
|
|
return NULL;
|
|
}
|
|
|
|
void intlist__delete(struct intlist *ilist)
|
|
{
|
|
if (ilist != NULL)
|
|
rblist__delete(&ilist->rblist);
|
|
}
|
|
|
|
struct int_node *intlist__entry(const struct intlist *ilist, unsigned int idx)
|
|
{
|
|
struct int_node *node = NULL;
|
|
struct rb_node *rb_node;
|
|
|
|
rb_node = rblist__entry(&ilist->rblist, idx);
|
|
if (rb_node)
|
|
node = container_of(rb_node, struct int_node, rb_node);
|
|
|
|
return node;
|
|
}
|