16c00db4bb
Pull AFS fixes from David Howells:
"Here's a set of patches that fix a number of bugs in the in-kernel AFS
client, including:
- Fix directory locking to not use individual page locks for
directory reading/scanning but rather to use a semaphore on the
afs_vnode struct as the directory contents must be read in a single
blob and data from different reads must not be mixed as the entire
contents may be shuffled about between reads.
- Fix address list parsing to handle port specifiers correctly.
- Only give up callback records on a server if we actually talked to
that server (we might not be able to access a server).
- Fix some callback handling bugs, including refcounting,
whole-volume callbacks and when callbacks actually get broken in
response to a CB.CallBack op.
- Fix some server/address rotation bugs, including giving up if we
can't probe a server; giving up if a server says it doesn't have a
volume, but there are more servers to try.
- Fix the decoding of fetched statuses to be OpenAFS compatible.
- Fix the handling of server lookups in Cache Manager ops (such as
CB.InitCallBackState3) to use a UUID if possible and to handle no
server being found.
- Fix a bug in server lookup where not all addresses are compared.
- Fix the non-encryption of calls that prevents some servers from
being accessed (this also requires an AF_RXRPC patch that has
already gone in through the net tree).
There's also a patch that adds tracepoints to log Cache Manager ops
that don't find a matching server, either by UUID or by address"
* tag 'afs-fixes-20180514' of git://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs:
afs: Fix the non-encryption of calls
afs: Fix CB.CallBack handling
afs: Fix whole-volume callback handling
afs: Fix afs_find_server search loop
afs: Fix the handling of an unfound server in CM operations
afs: Add a tracepoint to record callbacks from unlisted servers
afs: Fix the handling of CB.InitCallBackState3 to find the server by UUID
afs: Fix VNOVOL handling in address rotation
afs: Fix AFSFetchStatus decoder to provide OpenAFS compatibility
afs: Fix server rotation's handling of fileserver probe failure
afs: Fix refcounting in callback registration
afs: Fix giving up callbacks on server destruction
afs: Fix address list parsing
afs: Fix directory page locking
85 lines
1.6 KiB
C
85 lines
1.6 KiB
C
// SPDX-License-Identifier: GPL-2.0
|
|
#include "util.h"
|
|
#include "../debug.h"
|
|
|
|
|
|
/*
|
|
* Default error logging functions
|
|
*/
|
|
static int perf_stdio__error(const char *format, va_list args)
|
|
{
|
|
fprintf(stderr, "Error:\n");
|
|
vfprintf(stderr, format, args);
|
|
return 0;
|
|
}
|
|
|
|
static int perf_stdio__warning(const char *format, va_list args)
|
|
{
|
|
fprintf(stderr, "Warning:\n");
|
|
vfprintf(stderr, format, args);
|
|
return 0;
|
|
}
|
|
|
|
static struct perf_error_ops default_eops =
|
|
{
|
|
.error = perf_stdio__error,
|
|
.warning = perf_stdio__warning,
|
|
};
|
|
|
|
static struct perf_error_ops *perf_eops = &default_eops;
|
|
|
|
|
|
int ui__error(const char *format, ...)
|
|
{
|
|
int ret;
|
|
va_list args;
|
|
|
|
va_start(args, format);
|
|
ret = perf_eops->error(format, args);
|
|
va_end(args);
|
|
|
|
return ret;
|
|
}
|
|
|
|
int ui__warning(const char *format, ...)
|
|
{
|
|
int ret;
|
|
va_list args;
|
|
|
|
va_start(args, format);
|
|
ret = perf_eops->warning(format, args);
|
|
va_end(args);
|
|
|
|
return ret;
|
|
}
|
|
|
|
/**
|
|
* perf_error__register - Register error logging functions
|
|
* @eops: The pointer to error logging function struct
|
|
*
|
|
* Register UI-specific error logging functions. Before calling this,
|
|
* other logging functions should be unregistered, if any.
|
|
*/
|
|
int perf_error__register(struct perf_error_ops *eops)
|
|
{
|
|
if (perf_eops != &default_eops)
|
|
return -1;
|
|
|
|
perf_eops = eops;
|
|
return 0;
|
|
}
|
|
|
|
/**
|
|
* perf_error__unregister - Unregister error logging functions
|
|
* @eops: The pointer to error logging function struct
|
|
*
|
|
* Unregister already registered error logging functions.
|
|
*/
|
|
int perf_error__unregister(struct perf_error_ops *eops)
|
|
{
|
|
if (perf_eops != eops)
|
|
return -1;
|
|
|
|
perf_eops = &default_eops;
|
|
return 0;
|
|
}
|