16c00db4bb
Pull AFS fixes from David Howells:
"Here's a set of patches that fix a number of bugs in the in-kernel AFS
client, including:
- Fix directory locking to not use individual page locks for
directory reading/scanning but rather to use a semaphore on the
afs_vnode struct as the directory contents must be read in a single
blob and data from different reads must not be mixed as the entire
contents may be shuffled about between reads.
- Fix address list parsing to handle port specifiers correctly.
- Only give up callback records on a server if we actually talked to
that server (we might not be able to access a server).
- Fix some callback handling bugs, including refcounting,
whole-volume callbacks and when callbacks actually get broken in
response to a CB.CallBack op.
- Fix some server/address rotation bugs, including giving up if we
can't probe a server; giving up if a server says it doesn't have a
volume, but there are more servers to try.
- Fix the decoding of fetched statuses to be OpenAFS compatible.
- Fix the handling of server lookups in Cache Manager ops (such as
CB.InitCallBackState3) to use a UUID if possible and to handle no
server being found.
- Fix a bug in server lookup where not all addresses are compared.
- Fix the non-encryption of calls that prevents some servers from
being accessed (this also requires an AF_RXRPC patch that has
already gone in through the net tree).
There's also a patch that adds tracepoints to log Cache Manager ops
that don't find a matching server, either by UUID or by address"
* tag 'afs-fixes-20180514' of git://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs:
afs: Fix the non-encryption of calls
afs: Fix CB.CallBack handling
afs: Fix whole-volume callback handling
afs: Fix afs_find_server search loop
afs: Fix the handling of an unfound server in CM operations
afs: Add a tracepoint to record callbacks from unlisted servers
afs: Fix the handling of CB.InitCallBackState3 to find the server by UUID
afs: Fix VNOVOL handling in address rotation
afs: Fix AFSFetchStatus decoder to provide OpenAFS compatibility
afs: Fix server rotation's handling of fileserver probe failure
afs: Fix refcounting in callback registration
afs: Fix giving up callbacks on server destruction
afs: Fix address list parsing
afs: Fix directory page locking
132 lines
3.3 KiB
C
132 lines
3.3 KiB
C
// SPDX-License-Identifier: GPL-2.0
|
|
#include <elf.h>
|
|
#include <inttypes.h>
|
|
#include <sys/ttydefaults.h>
|
|
#include <string.h>
|
|
#include <linux/bitops.h>
|
|
#include "../../util/util.h"
|
|
#include "../../util/debug.h"
|
|
#include "../../util/symbol.h"
|
|
#include "../browser.h"
|
|
#include "../helpline.h"
|
|
#include "../keysyms.h"
|
|
#include "map.h"
|
|
|
|
#include "sane_ctype.h"
|
|
|
|
struct map_browser {
|
|
struct ui_browser b;
|
|
struct map *map;
|
|
u8 addrlen;
|
|
};
|
|
|
|
static void map_browser__write(struct ui_browser *browser, void *nd, int row)
|
|
{
|
|
struct symbol *sym = rb_entry(nd, struct symbol, rb_node);
|
|
struct map_browser *mb = container_of(browser, struct map_browser, b);
|
|
bool current_entry = ui_browser__is_current_entry(browser, row);
|
|
int width;
|
|
|
|
ui_browser__set_percent_color(browser, 0, current_entry);
|
|
ui_browser__printf(browser, "%*" PRIx64 " %*" PRIx64 " %c ",
|
|
mb->addrlen, sym->start, mb->addrlen, sym->end,
|
|
sym->binding == STB_GLOBAL ? 'g' :
|
|
sym->binding == STB_LOCAL ? 'l' : 'w');
|
|
width = browser->width - ((mb->addrlen * 2) + 4);
|
|
if (width > 0)
|
|
ui_browser__write_nstring(browser, sym->name, width);
|
|
}
|
|
|
|
/* FIXME uber-kludgy, see comment on cmd_report... */
|
|
static u32 *symbol__browser_index(struct symbol *browser)
|
|
{
|
|
return ((void *)browser) - sizeof(struct rb_node) - sizeof(u32);
|
|
}
|
|
|
|
static int map_browser__search(struct map_browser *browser)
|
|
{
|
|
char target[512];
|
|
struct symbol *sym;
|
|
int err = ui_browser__input_window("Search by name/addr",
|
|
"Prefix with 0x to search by address",
|
|
target, "ENTER: OK, ESC: Cancel", 0);
|
|
if (err != K_ENTER)
|
|
return -1;
|
|
|
|
if (target[0] == '0' && tolower(target[1]) == 'x') {
|
|
u64 addr = strtoull(target, NULL, 16);
|
|
sym = map__find_symbol(browser->map, addr);
|
|
} else
|
|
sym = map__find_symbol_by_name(browser->map, target);
|
|
|
|
if (sym != NULL) {
|
|
u32 *idx = symbol__browser_index(sym);
|
|
|
|
browser->b.top = &sym->rb_node;
|
|
browser->b.index = browser->b.top_idx = *idx;
|
|
} else
|
|
ui_helpline__fpush("%s not found!", target);
|
|
|
|
return 0;
|
|
}
|
|
|
|
static int map_browser__run(struct map_browser *browser)
|
|
{
|
|
int key;
|
|
|
|
if (ui_browser__show(&browser->b, browser->map->dso->long_name,
|
|
"Press ESC to exit, %s / to search",
|
|
verbose > 0 ? "" : "restart with -v to use") < 0)
|
|
return -1;
|
|
|
|
while (1) {
|
|
key = ui_browser__run(&browser->b, 0);
|
|
|
|
switch (key) {
|
|
case '/':
|
|
if (verbose > 0)
|
|
map_browser__search(browser);
|
|
default:
|
|
break;
|
|
case K_LEFT:
|
|
case K_ESC:
|
|
case 'q':
|
|
case CTRL('c'):
|
|
goto out;
|
|
}
|
|
}
|
|
out:
|
|
ui_browser__hide(&browser->b);
|
|
return key;
|
|
}
|
|
|
|
int map__browse(struct map *map)
|
|
{
|
|
struct map_browser mb = {
|
|
.b = {
|
|
.entries = &map->dso->symbols[map->type],
|
|
.refresh = ui_browser__rb_tree_refresh,
|
|
.seek = ui_browser__rb_tree_seek,
|
|
.write = map_browser__write,
|
|
},
|
|
.map = map,
|
|
};
|
|
struct rb_node *nd;
|
|
char tmp[BITS_PER_LONG / 4];
|
|
u64 maxaddr = 0;
|
|
|
|
for (nd = rb_first(mb.b.entries); nd; nd = rb_next(nd)) {
|
|
struct symbol *pos = rb_entry(nd, struct symbol, rb_node);
|
|
|
|
if (maxaddr < pos->end)
|
|
maxaddr = pos->end;
|
|
if (verbose > 0) {
|
|
u32 *idx = symbol__browser_index(pos);
|
|
*idx = mb.b.nr_entries;
|
|
}
|
|
++mb.b.nr_entries;
|
|
}
|
|
|
|
mb.addrlen = snprintf(tmp, sizeof(tmp), "%" PRIx64, maxaddr);
|
|
return map_browser__run(&mb);
|
|
}
|