16c00db4bb
Pull AFS fixes from David Howells:
"Here's a set of patches that fix a number of bugs in the in-kernel AFS
client, including:
- Fix directory locking to not use individual page locks for
directory reading/scanning but rather to use a semaphore on the
afs_vnode struct as the directory contents must be read in a single
blob and data from different reads must not be mixed as the entire
contents may be shuffled about between reads.
- Fix address list parsing to handle port specifiers correctly.
- Only give up callback records on a server if we actually talked to
that server (we might not be able to access a server).
- Fix some callback handling bugs, including refcounting,
whole-volume callbacks and when callbacks actually get broken in
response to a CB.CallBack op.
- Fix some server/address rotation bugs, including giving up if we
can't probe a server; giving up if a server says it doesn't have a
volume, but there are more servers to try.
- Fix the decoding of fetched statuses to be OpenAFS compatible.
- Fix the handling of server lookups in Cache Manager ops (such as
CB.InitCallBackState3) to use a UUID if possible and to handle no
server being found.
- Fix a bug in server lookup where not all addresses are compared.
- Fix the non-encryption of calls that prevents some servers from
being accessed (this also requires an AF_RXRPC patch that has
already gone in through the net tree).
There's also a patch that adds tracepoints to log Cache Manager ops
that don't find a matching server, either by UUID or by address"
* tag 'afs-fixes-20180514' of git://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs:
afs: Fix the non-encryption of calls
afs: Fix CB.CallBack handling
afs: Fix whole-volume callback handling
afs: Fix afs_find_server search loop
afs: Fix the handling of an unfound server in CM operations
afs: Add a tracepoint to record callbacks from unlisted servers
afs: Fix the handling of CB.InitCallBackState3 to find the server by UUID
afs: Fix VNOVOL handling in address rotation
afs: Fix AFSFetchStatus decoder to provide OpenAFS compatibility
afs: Fix server rotation's handling of fileserver probe failure
afs: Fix refcounting in callback registration
afs: Fix giving up callbacks on server destruction
afs: Fix address list parsing
afs: Fix directory page locking
101 lines
2.9 KiB
C
101 lines
2.9 KiB
C
/*
|
|
* trace/beauty/fcntl.c
|
|
*
|
|
* Copyright (C) 2017, Red Hat Inc, Arnaldo Carvalho de Melo <acme@redhat.com>
|
|
*
|
|
* Released under the GPL v2. (and only v2, not any later version)
|
|
*/
|
|
|
|
#include "trace/beauty/beauty.h"
|
|
#include <linux/kernel.h>
|
|
#include <uapi/linux/fcntl.h>
|
|
|
|
static size_t fcntl__scnprintf_getfd(unsigned long val, char *bf, size_t size)
|
|
{
|
|
return scnprintf(bf, size, "%s", val ? "CLOEXEC" : "0");
|
|
}
|
|
|
|
static size_t syscall_arg__scnprintf_fcntl_getfd(char *bf, size_t size, struct syscall_arg *arg)
|
|
{
|
|
return fcntl__scnprintf_getfd(arg->val, bf, size);
|
|
}
|
|
|
|
static size_t fcntl__scnprintf_getlease(unsigned long val, char *bf, size_t size)
|
|
{
|
|
static const char *fcntl_setlease[] = { "RDLCK", "WRLCK", "UNLCK", };
|
|
static DEFINE_STRARRAY(fcntl_setlease);
|
|
|
|
return strarray__scnprintf(&strarray__fcntl_setlease, bf, size, "%x", val);
|
|
}
|
|
|
|
static size_t syscall_arg__scnprintf_fcntl_getlease(char *bf, size_t size, struct syscall_arg *arg)
|
|
{
|
|
return fcntl__scnprintf_getlease(arg->val, bf, size);
|
|
}
|
|
|
|
size_t syscall_arg__scnprintf_fcntl_cmd(char *bf, size_t size, struct syscall_arg *arg)
|
|
{
|
|
if (arg->val == F_GETFL) {
|
|
syscall_arg__set_ret_scnprintf(arg, syscall_arg__scnprintf_open_flags);
|
|
goto mask_arg;
|
|
}
|
|
if (arg->val == F_GETFD) {
|
|
syscall_arg__set_ret_scnprintf(arg, syscall_arg__scnprintf_fcntl_getfd);
|
|
goto mask_arg;
|
|
}
|
|
if (arg->val == F_DUPFD_CLOEXEC || arg->val == F_DUPFD) {
|
|
syscall_arg__set_ret_scnprintf(arg, syscall_arg__scnprintf_fd);
|
|
goto out;
|
|
}
|
|
if (arg->val == F_GETOWN) {
|
|
syscall_arg__set_ret_scnprintf(arg, syscall_arg__scnprintf_pid);
|
|
goto mask_arg;
|
|
}
|
|
if (arg->val == F_GETLEASE) {
|
|
syscall_arg__set_ret_scnprintf(arg, syscall_arg__scnprintf_fcntl_getlease);
|
|
goto mask_arg;
|
|
}
|
|
/*
|
|
* Some commands ignore the third fcntl argument, "arg", so mask it
|
|
*/
|
|
if (arg->val == F_GET_SEALS ||
|
|
arg->val == F_GETSIG) {
|
|
mask_arg:
|
|
arg->mask |= (1 << 2);
|
|
}
|
|
out:
|
|
return syscall_arg__scnprintf_strarrays(bf, size, arg);
|
|
}
|
|
|
|
size_t syscall_arg__scnprintf_fcntl_arg(char *bf, size_t size, struct syscall_arg *arg)
|
|
{
|
|
int cmd = syscall_arg__val(arg, 1);
|
|
|
|
if (cmd == F_DUPFD)
|
|
return syscall_arg__scnprintf_fd(bf, size, arg);
|
|
|
|
if (cmd == F_SETFD)
|
|
return fcntl__scnprintf_getfd(arg->val, bf, size);
|
|
|
|
if (cmd == F_SETFL)
|
|
return open__scnprintf_flags(arg->val, bf, size);
|
|
|
|
if (cmd == F_SETOWN)
|
|
return syscall_arg__scnprintf_pid(bf, size, arg);
|
|
|
|
if (cmd == F_SETLEASE)
|
|
return fcntl__scnprintf_getlease(arg->val, bf, size);
|
|
/*
|
|
* We still don't grab the contents of pointers on entry or exit,
|
|
* so just print them as hex numbers
|
|
*/
|
|
if (cmd == F_SETLK || cmd == F_SETLKW || cmd == F_GETLK ||
|
|
cmd == F_OFD_SETLK || cmd == F_OFD_SETLKW || cmd == F_OFD_GETLK ||
|
|
cmd == F_GETOWN_EX || cmd == F_SETOWN_EX ||
|
|
cmd == F_GET_RW_HINT || cmd == F_SET_RW_HINT ||
|
|
cmd == F_GET_FILE_RW_HINT || cmd == F_SET_FILE_RW_HINT)
|
|
return syscall_arg__scnprintf_hex(bf, size, arg);
|
|
|
|
return syscall_arg__scnprintf_long(bf, size, arg);
|
|
}
|