16c00db4bb
Pull AFS fixes from David Howells:
"Here's a set of patches that fix a number of bugs in the in-kernel AFS
client, including:
- Fix directory locking to not use individual page locks for
directory reading/scanning but rather to use a semaphore on the
afs_vnode struct as the directory contents must be read in a single
blob and data from different reads must not be mixed as the entire
contents may be shuffled about between reads.
- Fix address list parsing to handle port specifiers correctly.
- Only give up callback records on a server if we actually talked to
that server (we might not be able to access a server).
- Fix some callback handling bugs, including refcounting,
whole-volume callbacks and when callbacks actually get broken in
response to a CB.CallBack op.
- Fix some server/address rotation bugs, including giving up if we
can't probe a server; giving up if a server says it doesn't have a
volume, but there are more servers to try.
- Fix the decoding of fetched statuses to be OpenAFS compatible.
- Fix the handling of server lookups in Cache Manager ops (such as
CB.InitCallBackState3) to use a UUID if possible and to handle no
server being found.
- Fix a bug in server lookup where not all addresses are compared.
- Fix the non-encryption of calls that prevents some servers from
being accessed (this also requires an AF_RXRPC patch that has
already gone in through the net tree).
There's also a patch that adds tracepoints to log Cache Manager ops
that don't find a matching server, either by UUID or by address"
* tag 'afs-fixes-20180514' of git://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs:
afs: Fix the non-encryption of calls
afs: Fix CB.CallBack handling
afs: Fix whole-volume callback handling
afs: Fix afs_find_server search loop
afs: Fix the handling of an unfound server in CM operations
afs: Add a tracepoint to record callbacks from unlisted servers
afs: Fix the handling of CB.InitCallBackState3 to find the server by UUID
afs: Fix VNOVOL handling in address rotation
afs: Fix AFSFetchStatus decoder to provide OpenAFS compatibility
afs: Fix server rotation's handling of fileserver probe failure
afs: Fix refcounting in callback registration
afs: Fix giving up callbacks on server destruction
afs: Fix address list parsing
afs: Fix directory page locking
58 lines
1.4 KiB
C
58 lines
1.4 KiB
C
// SPDX-License-Identifier: GPL-2.0
|
|
#include "print_binary.h"
|
|
#include <linux/log2.h>
|
|
#include "sane_ctype.h"
|
|
|
|
int binary__fprintf(unsigned char *data, size_t len,
|
|
size_t bytes_per_line, binary__fprintf_t printer,
|
|
void *extra, FILE *fp)
|
|
{
|
|
size_t i, j, mask;
|
|
int printed = 0;
|
|
|
|
if (!printer)
|
|
return 0;
|
|
|
|
bytes_per_line = roundup_pow_of_two(bytes_per_line);
|
|
mask = bytes_per_line - 1;
|
|
|
|
printed += printer(BINARY_PRINT_DATA_BEGIN, 0, extra, fp);
|
|
for (i = 0; i < len; i++) {
|
|
if ((i & mask) == 0) {
|
|
printed += printer(BINARY_PRINT_LINE_BEGIN, -1, extra, fp);
|
|
printed += printer(BINARY_PRINT_ADDR, i, extra, fp);
|
|
}
|
|
|
|
printed += printer(BINARY_PRINT_NUM_DATA, data[i], extra, fp);
|
|
|
|
if (((i & mask) == mask) || i == len - 1) {
|
|
for (j = 0; j < mask-(i & mask); j++)
|
|
printed += printer(BINARY_PRINT_NUM_PAD, -1, extra, fp);
|
|
|
|
printer(BINARY_PRINT_SEP, i, extra, fp);
|
|
for (j = i & ~mask; j <= i; j++)
|
|
printed += printer(BINARY_PRINT_CHAR_DATA, data[j], extra, fp);
|
|
for (j = 0; j < mask-(i & mask); j++)
|
|
printed += printer(BINARY_PRINT_CHAR_PAD, i, extra, fp);
|
|
printed += printer(BINARY_PRINT_LINE_END, -1, extra, fp);
|
|
}
|
|
}
|
|
printed += printer(BINARY_PRINT_DATA_END, -1, extra, fp);
|
|
return printed;
|
|
}
|
|
|
|
int is_printable_array(char *p, unsigned int len)
|
|
{
|
|
unsigned int i;
|
|
|
|
if (!p || !len || p[len - 1] != 0)
|
|
return 0;
|
|
|
|
len--;
|
|
|
|
for (i = 0; i < len; i++) {
|
|
if (!isprint(p[i]) && !isspace(p[i]))
|
|
return 0;
|
|
}
|
|
return 1;
|
|
}
|