16c00db4bb
Pull AFS fixes from David Howells:
"Here's a set of patches that fix a number of bugs in the in-kernel AFS
client, including:
- Fix directory locking to not use individual page locks for
directory reading/scanning but rather to use a semaphore on the
afs_vnode struct as the directory contents must be read in a single
blob and data from different reads must not be mixed as the entire
contents may be shuffled about between reads.
- Fix address list parsing to handle port specifiers correctly.
- Only give up callback records on a server if we actually talked to
that server (we might not be able to access a server).
- Fix some callback handling bugs, including refcounting,
whole-volume callbacks and when callbacks actually get broken in
response to a CB.CallBack op.
- Fix some server/address rotation bugs, including giving up if we
can't probe a server; giving up if a server says it doesn't have a
volume, but there are more servers to try.
- Fix the decoding of fetched statuses to be OpenAFS compatible.
- Fix the handling of server lookups in Cache Manager ops (such as
CB.InitCallBackState3) to use a UUID if possible and to handle no
server being found.
- Fix a bug in server lookup where not all addresses are compared.
- Fix the non-encryption of calls that prevents some servers from
being accessed (this also requires an AF_RXRPC patch that has
already gone in through the net tree).
There's also a patch that adds tracepoints to log Cache Manager ops
that don't find a matching server, either by UUID or by address"
* tag 'afs-fixes-20180514' of git://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs:
afs: Fix the non-encryption of calls
afs: Fix CB.CallBack handling
afs: Fix whole-volume callback handling
afs: Fix afs_find_server search loop
afs: Fix the handling of an unfound server in CM operations
afs: Add a tracepoint to record callbacks from unlisted servers
afs: Fix the handling of CB.InitCallBackState3 to find the server by UUID
afs: Fix VNOVOL handling in address rotation
afs: Fix AFSFetchStatus decoder to provide OpenAFS compatibility
afs: Fix server rotation's handling of fileserver probe failure
afs: Fix refcounting in callback registration
afs: Fix giving up callbacks on server destruction
afs: Fix address list parsing
afs: Fix directory page locking
69 lines
1.1 KiB
C
69 lines
1.1 KiB
C
// SPDX-License-Identifier: GPL-2.0
|
|
#include "units.h"
|
|
#include <inttypes.h>
|
|
#include <limits.h>
|
|
#include <stdlib.h>
|
|
#include <string.h>
|
|
#include <linux/kernel.h>
|
|
#include <linux/time64.h>
|
|
|
|
unsigned long parse_tag_value(const char *str, struct parse_tag *tags)
|
|
{
|
|
struct parse_tag *i = tags;
|
|
|
|
while (i->tag) {
|
|
char *s = strchr(str, i->tag);
|
|
|
|
if (s) {
|
|
unsigned long int value;
|
|
char *endptr;
|
|
|
|
value = strtoul(str, &endptr, 10);
|
|
if (s != endptr)
|
|
break;
|
|
|
|
if (value > ULONG_MAX / i->mult)
|
|
break;
|
|
value *= i->mult;
|
|
return value;
|
|
}
|
|
i++;
|
|
}
|
|
|
|
return (unsigned long) -1;
|
|
}
|
|
|
|
unsigned long convert_unit(unsigned long value, char *unit)
|
|
{
|
|
*unit = ' ';
|
|
|
|
if (value > 1000) {
|
|
value /= 1000;
|
|
*unit = 'K';
|
|
}
|
|
|
|
if (value > 1000) {
|
|
value /= 1000;
|
|
*unit = 'M';
|
|
}
|
|
|
|
if (value > 1000) {
|
|
value /= 1000;
|
|
*unit = 'G';
|
|
}
|
|
|
|
return value;
|
|
}
|
|
|
|
int unit_number__scnprintf(char *buf, size_t size, u64 n)
|
|
{
|
|
char unit[4] = "BKMG";
|
|
int i = 0;
|
|
|
|
while (((n / 1024) > 1) && (i < 3)) {
|
|
n /= 1024;
|
|
i++;
|
|
}
|
|
|
|
return scnprintf(buf, size, "%" PRIu64 "%c", n, unit[i]);
|
|
}
|