16c00db4bb
Pull AFS fixes from David Howells:
"Here's a set of patches that fix a number of bugs in the in-kernel AFS
client, including:
- Fix directory locking to not use individual page locks for
directory reading/scanning but rather to use a semaphore on the
afs_vnode struct as the directory contents must be read in a single
blob and data from different reads must not be mixed as the entire
contents may be shuffled about between reads.
- Fix address list parsing to handle port specifiers correctly.
- Only give up callback records on a server if we actually talked to
that server (we might not be able to access a server).
- Fix some callback handling bugs, including refcounting,
whole-volume callbacks and when callbacks actually get broken in
response to a CB.CallBack op.
- Fix some server/address rotation bugs, including giving up if we
can't probe a server; giving up if a server says it doesn't have a
volume, but there are more servers to try.
- Fix the decoding of fetched statuses to be OpenAFS compatible.
- Fix the handling of server lookups in Cache Manager ops (such as
CB.InitCallBackState3) to use a UUID if possible and to handle no
server being found.
- Fix a bug in server lookup where not all addresses are compared.
- Fix the non-encryption of calls that prevents some servers from
being accessed (this also requires an AF_RXRPC patch that has
already gone in through the net tree).
There's also a patch that adds tracepoints to log Cache Manager ops
that don't find a matching server, either by UUID or by address"
* tag 'afs-fixes-20180514' of git://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs:
afs: Fix the non-encryption of calls
afs: Fix CB.CallBack handling
afs: Fix whole-volume callback handling
afs: Fix afs_find_server search loop
afs: Fix the handling of an unfound server in CM operations
afs: Add a tracepoint to record callbacks from unlisted servers
afs: Fix the handling of CB.InitCallBackState3 to find the server by UUID
afs: Fix VNOVOL handling in address rotation
afs: Fix AFSFetchStatus decoder to provide OpenAFS compatibility
afs: Fix server rotation's handling of fileserver probe failure
afs: Fix refcounting in callback registration
afs: Fix giving up callbacks on server destruction
afs: Fix address list parsing
afs: Fix directory page locking
116 lines
2.5 KiB
C
116 lines
2.5 KiB
C
// SPDX-License-Identifier: GPL-2.0
|
|
|
|
#include <stdio.h>
|
|
#include <unistd.h>
|
|
#include <stdlib.h>
|
|
#include <errno.h>
|
|
#include <sys/types.h>
|
|
#include <sys/stat.h>
|
|
#include <fcntl.h>
|
|
#include <linux/kernel.h>
|
|
#include <linux/err.h>
|
|
#include <traceevent/event-parse.h>
|
|
#include <api/fs/tracing_path.h>
|
|
#include <api/fs/fs.h>
|
|
#include "trace-event.h"
|
|
#include "machine.h"
|
|
#include "util.h"
|
|
|
|
/*
|
|
* global trace_event object used by trace_event__tp_format
|
|
*
|
|
* TODO There's no cleanup call for this. Add some sort of
|
|
* __exit function support and call trace_event__cleanup
|
|
* there.
|
|
*/
|
|
static struct trace_event tevent;
|
|
static bool tevent_initialized;
|
|
|
|
int trace_event__init(struct trace_event *t)
|
|
{
|
|
struct pevent *pevent = pevent_alloc();
|
|
|
|
if (pevent) {
|
|
t->plugin_list = traceevent_load_plugins(pevent);
|
|
t->pevent = pevent;
|
|
}
|
|
|
|
return pevent ? 0 : -1;
|
|
}
|
|
|
|
static int trace_event__init2(void)
|
|
{
|
|
int be = traceevent_host_bigendian();
|
|
struct pevent *pevent;
|
|
|
|
if (trace_event__init(&tevent))
|
|
return -1;
|
|
|
|
pevent = tevent.pevent;
|
|
pevent_set_flag(pevent, PEVENT_NSEC_OUTPUT);
|
|
pevent_set_file_bigendian(pevent, be);
|
|
pevent_set_host_bigendian(pevent, be);
|
|
tevent_initialized = true;
|
|
return 0;
|
|
}
|
|
|
|
int trace_event__register_resolver(struct machine *machine,
|
|
pevent_func_resolver_t *func)
|
|
{
|
|
if (!tevent_initialized && trace_event__init2())
|
|
return -1;
|
|
|
|
return pevent_set_function_resolver(tevent.pevent, func, machine);
|
|
}
|
|
|
|
void trace_event__cleanup(struct trace_event *t)
|
|
{
|
|
traceevent_unload_plugins(t->plugin_list, t->pevent);
|
|
pevent_free(t->pevent);
|
|
}
|
|
|
|
/*
|
|
* Returns pointer with encoded error via <linux/err.h> interface.
|
|
*/
|
|
static struct event_format*
|
|
tp_format(const char *sys, const char *name)
|
|
{
|
|
struct pevent *pevent = tevent.pevent;
|
|
struct event_format *event = NULL;
|
|
char path[PATH_MAX];
|
|
size_t size;
|
|
char *data;
|
|
int err;
|
|
|
|
scnprintf(path, PATH_MAX, "%s/%s/%s/format",
|
|
tracing_events_path, sys, name);
|
|
|
|
err = filename__read_str(path, &data, &size);
|
|
if (err)
|
|
return ERR_PTR(err);
|
|
|
|
pevent_parse_format(pevent, &event, data, size, sys);
|
|
|
|
free(data);
|
|
return event;
|
|
}
|
|
|
|
/*
|
|
* Returns pointer with encoded error via <linux/err.h> interface.
|
|
*/
|
|
struct event_format*
|
|
trace_event__tp_format(const char *sys, const char *name)
|
|
{
|
|
if (!tevent_initialized && trace_event__init2())
|
|
return ERR_PTR(-ENOMEM);
|
|
|
|
return tp_format(sys, name);
|
|
}
|
|
|
|
struct event_format *trace_event__tp_format_id(int id)
|
|
{
|
|
if (!tevent_initialized && trace_event__init2())
|
|
return ERR_PTR(-ENOMEM);
|
|
|
|
return pevent_find_event(tevent.pevent, id);
|
|
}
|