16c00db4bb
Pull AFS fixes from David Howells:
"Here's a set of patches that fix a number of bugs in the in-kernel AFS
client, including:
- Fix directory locking to not use individual page locks for
directory reading/scanning but rather to use a semaphore on the
afs_vnode struct as the directory contents must be read in a single
blob and data from different reads must not be mixed as the entire
contents may be shuffled about between reads.
- Fix address list parsing to handle port specifiers correctly.
- Only give up callback records on a server if we actually talked to
that server (we might not be able to access a server).
- Fix some callback handling bugs, including refcounting,
whole-volume callbacks and when callbacks actually get broken in
response to a CB.CallBack op.
- Fix some server/address rotation bugs, including giving up if we
can't probe a server; giving up if a server says it doesn't have a
volume, but there are more servers to try.
- Fix the decoding of fetched statuses to be OpenAFS compatible.
- Fix the handling of server lookups in Cache Manager ops (such as
CB.InitCallBackState3) to use a UUID if possible and to handle no
server being found.
- Fix a bug in server lookup where not all addresses are compared.
- Fix the non-encryption of calls that prevents some servers from
being accessed (this also requires an AF_RXRPC patch that has
already gone in through the net tree).
There's also a patch that adds tracepoints to log Cache Manager ops
that don't find a matching server, either by UUID or by address"
* tag 'afs-fixes-20180514' of git://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs:
afs: Fix the non-encryption of calls
afs: Fix CB.CallBack handling
afs: Fix whole-volume callback handling
afs: Fix afs_find_server search loop
afs: Fix the handling of an unfound server in CM operations
afs: Add a tracepoint to record callbacks from unlisted servers
afs: Fix the handling of CB.InitCallBackState3 to find the server by UUID
afs: Fix VNOVOL handling in address rotation
afs: Fix AFSFetchStatus decoder to provide OpenAFS compatibility
afs: Fix server rotation's handling of fileserver probe failure
afs: Fix refcounting in callback registration
afs: Fix giving up callbacks on server destruction
afs: Fix address list parsing
afs: Fix directory page locking
62 lines
1.6 KiB
C
62 lines
1.6 KiB
C
// SPDX-License-Identifier: GPL-2.0
|
|
#include "util/debug.h"
|
|
#include "util/expr.h"
|
|
#include "tests.h"
|
|
#include <stdlib.h>
|
|
|
|
static int test(struct parse_ctx *ctx, const char *e, double val2)
|
|
{
|
|
double val;
|
|
|
|
if (expr__parse(&val, ctx, &e))
|
|
TEST_ASSERT_VAL("parse test failed", 0);
|
|
TEST_ASSERT_VAL("unexpected value", val == val2);
|
|
return 0;
|
|
}
|
|
|
|
int test__expr(struct test *t __maybe_unused, int subtest __maybe_unused)
|
|
{
|
|
const char *p;
|
|
const char **other;
|
|
double val;
|
|
int ret;
|
|
struct parse_ctx ctx;
|
|
int num_other;
|
|
|
|
expr__ctx_init(&ctx);
|
|
expr__add_id(&ctx, "FOO", 1);
|
|
expr__add_id(&ctx, "BAR", 2);
|
|
|
|
ret = test(&ctx, "1+1", 2);
|
|
ret |= test(&ctx, "FOO+BAR", 3);
|
|
ret |= test(&ctx, "(BAR/2)%2", 1);
|
|
ret |= test(&ctx, "1 - -4", 5);
|
|
ret |= test(&ctx, "(FOO-1)*2 + (BAR/2)%2 - -4", 5);
|
|
ret |= test(&ctx, "1-1 | 1", 1);
|
|
ret |= test(&ctx, "1-1 & 1", 0);
|
|
ret |= test(&ctx, "min(1,2) + 1", 2);
|
|
ret |= test(&ctx, "max(1,2) + 1", 3);
|
|
ret |= test(&ctx, "1+1 if 3*4 else 0", 2);
|
|
|
|
if (ret)
|
|
return ret;
|
|
|
|
p = "FOO/0";
|
|
ret = expr__parse(&val, &ctx, &p);
|
|
TEST_ASSERT_VAL("division by zero", ret == 1);
|
|
|
|
p = "BAR/";
|
|
ret = expr__parse(&val, &ctx, &p);
|
|
TEST_ASSERT_VAL("missing operand", ret == 1);
|
|
|
|
TEST_ASSERT_VAL("find other",
|
|
expr__find_other("FOO + BAR + BAZ + BOZO", "FOO", &other, &num_other) == 0);
|
|
TEST_ASSERT_VAL("find other", num_other == 3);
|
|
TEST_ASSERT_VAL("find other", !strcmp(other[0], "BAR"));
|
|
TEST_ASSERT_VAL("find other", !strcmp(other[1], "BAZ"));
|
|
TEST_ASSERT_VAL("find other", !strcmp(other[2], "BOZO"));
|
|
TEST_ASSERT_VAL("find other", other[3] == NULL);
|
|
free((void *)other);
|
|
|
|
return 0;
|
|
}
|