16c00db4bb
Pull AFS fixes from David Howells:
"Here's a set of patches that fix a number of bugs in the in-kernel AFS
client, including:
- Fix directory locking to not use individual page locks for
directory reading/scanning but rather to use a semaphore on the
afs_vnode struct as the directory contents must be read in a single
blob and data from different reads must not be mixed as the entire
contents may be shuffled about between reads.
- Fix address list parsing to handle port specifiers correctly.
- Only give up callback records on a server if we actually talked to
that server (we might not be able to access a server).
- Fix some callback handling bugs, including refcounting,
whole-volume callbacks and when callbacks actually get broken in
response to a CB.CallBack op.
- Fix some server/address rotation bugs, including giving up if we
can't probe a server; giving up if a server says it doesn't have a
volume, but there are more servers to try.
- Fix the decoding of fetched statuses to be OpenAFS compatible.
- Fix the handling of server lookups in Cache Manager ops (such as
CB.InitCallBackState3) to use a UUID if possible and to handle no
server being found.
- Fix a bug in server lookup where not all addresses are compared.
- Fix the non-encryption of calls that prevents some servers from
being accessed (this also requires an AF_RXRPC patch that has
already gone in through the net tree).
There's also a patch that adds tracepoints to log Cache Manager ops
that don't find a matching server, either by UUID or by address"
* tag 'afs-fixes-20180514' of git://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs:
afs: Fix the non-encryption of calls
afs: Fix CB.CallBack handling
afs: Fix whole-volume callback handling
afs: Fix afs_find_server search loop
afs: Fix the handling of an unfound server in CM operations
afs: Add a tracepoint to record callbacks from unlisted servers
afs: Fix the handling of CB.InitCallBackState3 to find the server by UUID
afs: Fix VNOVOL handling in address rotation
afs: Fix AFSFetchStatus decoder to provide OpenAFS compatibility
afs: Fix server rotation's handling of fileserver probe failure
afs: Fix refcounting in callback registration
afs: Fix giving up callbacks on server destruction
afs: Fix address list parsing
afs: Fix directory page locking
119 lines
2.8 KiB
C
119 lines
2.8 KiB
C
// SPDX-License-Identifier: GPL-2.0
|
|
#include <errno.h>
|
|
#include <stdio.h>
|
|
#include <sys/epoll.h>
|
|
#include <util/evlist.h>
|
|
#include <linux/filter.h>
|
|
#include "tests.h"
|
|
#include "debug.h"
|
|
#include "probe-file.h"
|
|
#include "build-id.h"
|
|
|
|
/* To test SDT event, we need libelf support to scan elf binary */
|
|
#if defined(HAVE_SDT_EVENT) && defined(HAVE_LIBELF_SUPPORT)
|
|
|
|
#include <sys/sdt.h>
|
|
|
|
static int target_function(void)
|
|
{
|
|
DTRACE_PROBE(perf, test_target);
|
|
return TEST_OK;
|
|
}
|
|
|
|
/* Copied from builtin-buildid-cache.c */
|
|
static int build_id_cache__add_file(const char *filename)
|
|
{
|
|
char sbuild_id[SBUILD_ID_SIZE];
|
|
u8 build_id[BUILD_ID_SIZE];
|
|
int err;
|
|
|
|
err = filename__read_build_id(filename, &build_id, sizeof(build_id));
|
|
if (err < 0) {
|
|
pr_debug("Failed to read build id of %s\n", filename);
|
|
return err;
|
|
}
|
|
|
|
build_id__sprintf(build_id, sizeof(build_id), sbuild_id);
|
|
err = build_id_cache__add_s(sbuild_id, filename, NULL, false, false);
|
|
if (err < 0)
|
|
pr_debug("Failed to add build id cache of %s\n", filename);
|
|
return err;
|
|
}
|
|
|
|
static char *get_self_path(void)
|
|
{
|
|
char *buf = calloc(PATH_MAX, sizeof(char));
|
|
|
|
if (buf && readlink("/proc/self/exe", buf, PATH_MAX - 1) < 0) {
|
|
pr_debug("Failed to get correct path of perf\n");
|
|
free(buf);
|
|
return NULL;
|
|
}
|
|
return buf;
|
|
}
|
|
|
|
static int search_cached_probe(const char *target,
|
|
const char *group, const char *event)
|
|
{
|
|
struct probe_cache *cache = probe_cache__new(target, NULL);
|
|
int ret = 0;
|
|
|
|
if (!cache) {
|
|
pr_debug("Failed to open probe cache of %s\n", target);
|
|
return -EINVAL;
|
|
}
|
|
|
|
if (!probe_cache__find_by_name(cache, group, event)) {
|
|
pr_debug("Failed to find %s:%s in the cache\n", group, event);
|
|
ret = -ENOENT;
|
|
}
|
|
probe_cache__delete(cache);
|
|
|
|
return ret;
|
|
}
|
|
|
|
int test__sdt_event(struct test *test __maybe_unused, int subtests __maybe_unused)
|
|
{
|
|
int ret = TEST_FAIL;
|
|
char __tempdir[] = "./test-buildid-XXXXXX";
|
|
char *tempdir = NULL, *myself = get_self_path();
|
|
|
|
if (myself == NULL || mkdtemp(__tempdir) == NULL) {
|
|
pr_debug("Failed to make a tempdir for build-id cache\n");
|
|
goto error;
|
|
}
|
|
/* Note that buildid_dir must be an absolute path */
|
|
tempdir = realpath(__tempdir, NULL);
|
|
if (tempdir == NULL)
|
|
goto error_rmdir;
|
|
|
|
/* At first, scan itself */
|
|
set_buildid_dir(tempdir);
|
|
if (build_id_cache__add_file(myself) < 0)
|
|
goto error_rmdir;
|
|
|
|
/* Open a cache and make sure the SDT is stored */
|
|
if (search_cached_probe(myself, "sdt_perf", "test_target") < 0)
|
|
goto error_rmdir;
|
|
|
|
/* TBD: probing on the SDT event and collect logs */
|
|
|
|
/* Call the target and get an event */
|
|
ret = target_function();
|
|
|
|
error_rmdir:
|
|
/* Cleanup temporary buildid dir */
|
|
rm_rf(__tempdir);
|
|
error:
|
|
free(tempdir);
|
|
free(myself);
|
|
return ret;
|
|
}
|
|
#else
|
|
int test__sdt_event(struct test *test __maybe_unused, int subtests __maybe_unused)
|
|
{
|
|
pr_debug("Skip SDT event test because SDT support is not compiled\n");
|
|
return TEST_SKIP;
|
|
}
|
|
#endif
|