16c00db4bb
Pull AFS fixes from David Howells:
"Here's a set of patches that fix a number of bugs in the in-kernel AFS
client, including:
- Fix directory locking to not use individual page locks for
directory reading/scanning but rather to use a semaphore on the
afs_vnode struct as the directory contents must be read in a single
blob and data from different reads must not be mixed as the entire
contents may be shuffled about between reads.
- Fix address list parsing to handle port specifiers correctly.
- Only give up callback records on a server if we actually talked to
that server (we might not be able to access a server).
- Fix some callback handling bugs, including refcounting,
whole-volume callbacks and when callbacks actually get broken in
response to a CB.CallBack op.
- Fix some server/address rotation bugs, including giving up if we
can't probe a server; giving up if a server says it doesn't have a
volume, but there are more servers to try.
- Fix the decoding of fetched statuses to be OpenAFS compatible.
- Fix the handling of server lookups in Cache Manager ops (such as
CB.InitCallBackState3) to use a UUID if possible and to handle no
server being found.
- Fix a bug in server lookup where not all addresses are compared.
- Fix the non-encryption of calls that prevents some servers from
being accessed (this also requires an AF_RXRPC patch that has
already gone in through the net tree).
There's also a patch that adds tracepoints to log Cache Manager ops
that don't find a matching server, either by UUID or by address"
* tag 'afs-fixes-20180514' of git://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs:
afs: Fix the non-encryption of calls
afs: Fix CB.CallBack handling
afs: Fix whole-volume callback handling
afs: Fix afs_find_server search loop
afs: Fix the handling of an unfound server in CM operations
afs: Add a tracepoint to record callbacks from unlisted servers
afs: Fix the handling of CB.InitCallBackState3 to find the server by UUID
afs: Fix VNOVOL handling in address rotation
afs: Fix AFSFetchStatus decoder to provide OpenAFS compatibility
afs: Fix server rotation's handling of fileserver probe failure
afs: Fix refcounting in callback registration
afs: Fix giving up callbacks on server destruction
afs: Fix address list parsing
afs: Fix directory page locking
108 lines
2.4 KiB
C
108 lines
2.4 KiB
C
// SPDX-License-Identifier: GPL-2.0
|
|
#include <linux/kernel.h>
|
|
#include <linux/types.h>
|
|
#include <stddef.h>
|
|
|
|
#include "tests.h"
|
|
|
|
#include "event.h"
|
|
#include "evlist.h"
|
|
#include "header.h"
|
|
#include "util.h"
|
|
#include "debug.h"
|
|
|
|
static int process_event(struct perf_evlist **pevlist, union perf_event *event)
|
|
{
|
|
struct perf_sample sample;
|
|
|
|
if (event->header.type == PERF_RECORD_HEADER_ATTR) {
|
|
if (perf_event__process_attr(NULL, event, pevlist)) {
|
|
pr_debug("perf_event__process_attr failed\n");
|
|
return -1;
|
|
}
|
|
return 0;
|
|
}
|
|
|
|
if (event->header.type >= PERF_RECORD_USER_TYPE_START)
|
|
return -1;
|
|
|
|
if (!*pevlist)
|
|
return -1;
|
|
|
|
if (perf_evlist__parse_sample(*pevlist, event, &sample)) {
|
|
pr_debug("perf_evlist__parse_sample failed\n");
|
|
return -1;
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
|
|
static int process_events(union perf_event **events, size_t count)
|
|
{
|
|
struct perf_evlist *evlist = NULL;
|
|
int err = 0;
|
|
size_t i;
|
|
|
|
for (i = 0; i < count && !err; i++)
|
|
err = process_event(&evlist, events[i]);
|
|
|
|
perf_evlist__delete(evlist);
|
|
|
|
return err;
|
|
}
|
|
|
|
struct test_attr_event {
|
|
struct perf_event_header header;
|
|
struct perf_event_attr attr;
|
|
u64 id;
|
|
};
|
|
|
|
/**
|
|
* test__parse_no_sample_id_all - test parsing with no sample_id_all bit set.
|
|
*
|
|
* This function tests parsing data produced on kernel's that do not support the
|
|
* sample_id_all bit. Without the sample_id_all bit, non-sample events (such as
|
|
* mmap events) do not have an id sample appended, and consequently logic
|
|
* designed to determine the id will not work. That case happens when there is
|
|
* more than one selected event, so this test processes three events: 2
|
|
* attributes representing the selected events and one mmap event.
|
|
*
|
|
* Return: %0 on success, %-1 if the test fails.
|
|
*/
|
|
int test__parse_no_sample_id_all(struct test *test __maybe_unused, int subtest __maybe_unused)
|
|
{
|
|
int err;
|
|
|
|
struct test_attr_event event1 = {
|
|
.header = {
|
|
.type = PERF_RECORD_HEADER_ATTR,
|
|
.size = sizeof(struct test_attr_event),
|
|
},
|
|
.id = 1,
|
|
};
|
|
struct test_attr_event event2 = {
|
|
.header = {
|
|
.type = PERF_RECORD_HEADER_ATTR,
|
|
.size = sizeof(struct test_attr_event),
|
|
},
|
|
.id = 2,
|
|
};
|
|
struct mmap_event event3 = {
|
|
.header = {
|
|
.type = PERF_RECORD_MMAP,
|
|
.size = sizeof(struct mmap_event),
|
|
},
|
|
};
|
|
union perf_event *events[] = {
|
|
(union perf_event *)&event1,
|
|
(union perf_event *)&event2,
|
|
(union perf_event *)&event3,
|
|
};
|
|
|
|
err = process_events(events, ARRAY_SIZE(events));
|
|
if (err)
|
|
return -1;
|
|
|
|
return 0;
|
|
}
|