16c00db4bb
Pull AFS fixes from David Howells:
"Here's a set of patches that fix a number of bugs in the in-kernel AFS
client, including:
- Fix directory locking to not use individual page locks for
directory reading/scanning but rather to use a semaphore on the
afs_vnode struct as the directory contents must be read in a single
blob and data from different reads must not be mixed as the entire
contents may be shuffled about between reads.
- Fix address list parsing to handle port specifiers correctly.
- Only give up callback records on a server if we actually talked to
that server (we might not be able to access a server).
- Fix some callback handling bugs, including refcounting,
whole-volume callbacks and when callbacks actually get broken in
response to a CB.CallBack op.
- Fix some server/address rotation bugs, including giving up if we
can't probe a server; giving up if a server says it doesn't have a
volume, but there are more servers to try.
- Fix the decoding of fetched statuses to be OpenAFS compatible.
- Fix the handling of server lookups in Cache Manager ops (such as
CB.InitCallBackState3) to use a UUID if possible and to handle no
server being found.
- Fix a bug in server lookup where not all addresses are compared.
- Fix the non-encryption of calls that prevents some servers from
being accessed (this also requires an AF_RXRPC patch that has
already gone in through the net tree).
There's also a patch that adds tracepoints to log Cache Manager ops
that don't find a matching server, either by UUID or by address"
* tag 'afs-fixes-20180514' of git://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs:
afs: Fix the non-encryption of calls
afs: Fix CB.CallBack handling
afs: Fix whole-volume callback handling
afs: Fix afs_find_server search loop
afs: Fix the handling of an unfound server in CM operations
afs: Add a tracepoint to record callbacks from unlisted servers
afs: Fix the handling of CB.InitCallBackState3 to find the server by UUID
afs: Fix VNOVOL handling in address rotation
afs: Fix AFSFetchStatus decoder to provide OpenAFS compatibility
afs: Fix server rotation's handling of fileserver probe failure
afs: Fix refcounting in callback registration
afs: Fix giving up callbacks on server destruction
afs: Fix address list parsing
afs: Fix directory page locking
120 lines
2.8 KiB
C
120 lines
2.8 KiB
C
#include <stdbool.h>
|
|
#include <linux/kernel.h>
|
|
#include <linux/types.h>
|
|
#include <linux/bitops.h>
|
|
#include <linux/log2.h>
|
|
|
|
#include "../../util/evlist.h"
|
|
#include "../../util/auxtrace.h"
|
|
#include "../../util/evsel.h"
|
|
|
|
#define PERF_EVENT_CPUM_SF 0xB0000 /* Event: Basic-sampling */
|
|
#define PERF_EVENT_CPUM_SF_DIAG 0xBD000 /* Event: Combined-sampling */
|
|
#define DEFAULT_AUX_PAGES 128
|
|
#define DEFAULT_FREQ 4000
|
|
|
|
static void cpumsf_free(struct auxtrace_record *itr)
|
|
{
|
|
free(itr);
|
|
}
|
|
|
|
static size_t cpumsf_info_priv_size(struct auxtrace_record *itr __maybe_unused,
|
|
struct perf_evlist *evlist __maybe_unused)
|
|
{
|
|
return 0;
|
|
}
|
|
|
|
static int
|
|
cpumsf_info_fill(struct auxtrace_record *itr __maybe_unused,
|
|
struct perf_session *session __maybe_unused,
|
|
struct auxtrace_info_event *auxtrace_info __maybe_unused,
|
|
size_t priv_size __maybe_unused)
|
|
{
|
|
return 0;
|
|
}
|
|
|
|
static unsigned long
|
|
cpumsf_reference(struct auxtrace_record *itr __maybe_unused)
|
|
{
|
|
return 0;
|
|
}
|
|
|
|
static int
|
|
cpumsf_recording_options(struct auxtrace_record *ar __maybe_unused,
|
|
struct perf_evlist *evlist __maybe_unused,
|
|
struct record_opts *opts)
|
|
{
|
|
unsigned int factor = 1;
|
|
unsigned int pages;
|
|
|
|
opts->full_auxtrace = true;
|
|
|
|
/*
|
|
* The AUX buffer size should be set properly to avoid
|
|
* overflow of samples if it is not set explicitly.
|
|
* DEFAULT_AUX_PAGES is an proper size when sampling frequency
|
|
* is DEFAULT_FREQ. It is expected to hold about 1/2 second
|
|
* of sampling data. The size used for AUX buffer will scale
|
|
* according to the specified frequency and DEFAULT_FREQ.
|
|
*/
|
|
if (!opts->auxtrace_mmap_pages) {
|
|
if (opts->user_freq != UINT_MAX)
|
|
factor = (opts->user_freq + DEFAULT_FREQ
|
|
- 1) / DEFAULT_FREQ;
|
|
pages = DEFAULT_AUX_PAGES * factor;
|
|
opts->auxtrace_mmap_pages = roundup_pow_of_two(pages);
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
|
|
static int
|
|
cpumsf_parse_snapshot_options(struct auxtrace_record *itr __maybe_unused,
|
|
struct record_opts *opts __maybe_unused,
|
|
const char *str __maybe_unused)
|
|
{
|
|
return 0;
|
|
}
|
|
|
|
/*
|
|
* auxtrace_record__init is called when perf record
|
|
* check if the event really need auxtrace
|
|
*/
|
|
struct auxtrace_record *auxtrace_record__init(struct perf_evlist *evlist,
|
|
int *err)
|
|
{
|
|
struct auxtrace_record *aux;
|
|
struct perf_evsel *pos;
|
|
int diagnose = 0;
|
|
|
|
*err = 0;
|
|
if (evlist->nr_entries == 0)
|
|
return NULL;
|
|
|
|
evlist__for_each_entry(evlist, pos) {
|
|
if (pos->attr.config == PERF_EVENT_CPUM_SF_DIAG) {
|
|
diagnose = 1;
|
|
break;
|
|
}
|
|
}
|
|
|
|
if (!diagnose)
|
|
return NULL;
|
|
|
|
/* sampling in diagnose mode. alloc aux buffer */
|
|
aux = zalloc(sizeof(*aux));
|
|
if (aux == NULL) {
|
|
*err = -ENOMEM;
|
|
return NULL;
|
|
}
|
|
|
|
aux->parse_snapshot_options = cpumsf_parse_snapshot_options;
|
|
aux->recording_options = cpumsf_recording_options;
|
|
aux->info_priv_size = cpumsf_info_priv_size;
|
|
aux->info_fill = cpumsf_info_fill;
|
|
aux->free = cpumsf_free;
|
|
aux->reference = cpumsf_reference;
|
|
|
|
return aux;
|
|
}
|