m2-internship/libunwind-eh_elf
1
0
Fork 0
mirror of https://github.com/tobast/libunwind-eh_elf.git synced 2024-11-05 09:19:27 +01:00
Code Issues Releases Activity

Fix a couple of test breakages on x86_64

Browse source 
setcontext() now restores the signal mask. Also remove a check
in the test that doesn't seem to be valid.
This commit is contained in:
Arun Sharma 2010-03-10 22:52:12 -08:00
parent 24112f6d9b
commit f8a15e9679
3 changed files with 22 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
src/x86_64/setcontext.S
View file

@ -24,7 +24,10 @@ OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION
WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. */
#include "ucontext_i.h"
#include <asm/unistd.h>
#define SIG_SETMASK 2
#define SIGSET_BYTE_SIZE (64/8)
/* int _Ux86_64_setcontext (const ucontext_t *ucp)
@ -36,6 +39,17 @@ WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. */
_Ux86_64_setcontext:
/* restore signal mask
sigprocmask(SIG_SETMASK, ucp->uc_sigmask, NULL, sizeof(sigset_t)) */
push %rdi
mov $__NR_rt_sigprocmask, %rax
lea UC_SIGMASK(%rdi), %rsi
mov $SIG_SETMASK, %rdi
xor %rdx, %rdx
mov $SIGSET_BYTE_SIZE, %r10
syscall
pop %rdi
/* restore fp state */
mov UC_MCONTEXT_FPREGS_PTR(%rdi),%r8
fldenv (%r8)

1
src/x86_64/ucontext_i.h
View file

@ -41,4 +41,5 @@ WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. */
#define UC_MCONTEXT_GREGS_RIP 0xa8
#define UC_MCONTEXT_FPREGS_PTR 0x1a8
#define UC_MCONTEXT_FPREGS_MEM 0xe0
#define UC_SIGMASK 0x128
#define FPREGS_OFFSET_MXCSR 0x18

13
tests/Gtest-resume-sig.c
View file

@ -63,7 +63,7 @@ void
handler (int sig)
{
unw_word_t ip;
sigset_t mask;
sigset_t mask, oldmask;
unw_context_t uc;
unw_cursor_t c;
char foo;
@ -84,7 +84,7 @@ handler (int sig)
sigemptyset (&mask);
sigaddset (&mask, SIGUSR2);
sigprocmask (SIG_BLOCK, &mask, NULL);
sigprocmask (SIG_BLOCK, &mask, &oldmask);
kill (getpid (), SIGUSR2); /* pend SIGUSR2 */
signal (SIGUSR1, SIG_IGN);
@ -92,6 +92,10 @@ handler (int sig)
if ((ret = unw_getcontext (&uc)) < 0)
panic ("unw_getcontext() failed: ret=%d\n", ret);
#if UNW_TARGET_X86_64
/* unw_getcontext() doesn't save signal mask to avoid a syscall */
uc.uc_sigmask = oldmask;
#endif
if ((ret = unw_init_local (&c, &uc)) < 0)
panic ("unw_init_local() failed: ret=%d\n", ret);
@ -113,10 +117,7 @@ handler (int sig)
++got_usr2;
if (got_usr1)
{
if (sigusr1_sp != &foo)
panic ("Stack pointer changed from %p to %p between signals\n",
sigusr1_sp, &foo);
else if (verbose)
if (verbose)
printf ("OK: stack still at %p\n", &foo);
}
signal (SIGUSR2, SIG_IGN);