m2-internship/libunwind-eh_elf
1
0
Fork 0
mirror of https://github.com/tobast/libunwind-eh_elf.git synced 2024-11-17 13:47:37 +01:00
Code Issues Releases Activity

coredump: simplify bad regnum checks a little

Browse source 
We always want to reject negative regnums since we use it as an index,
so make it a common check at the top for all arches.
This commit is contained in:
Mike Frysinger 2017-02-13 21:32:54 -05:00 committed by Dave Watson
parent 00cca00716
commit f3f456c0d1
1 changed files with 8 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
src/coredump/_UCD_access_reg_linux.c
View file

@ -39,17 +39,20 @@ _UCD_access_reg (unw_addr_space_t as,
return -UNW_EINVAL; return -UNW_EINVAL;
} }
if (regnum < 0)
goto badreg;
#if defined(UNW_TARGET_AARCH64) #if defined(UNW_TARGET_AARCH64)
if (regnum < 0 || regnum >= UNW_AARCH64_FPCR) if (regnum >= UNW_AARCH64_FPCR)
goto badreg; goto badreg;
#elif defined(UNW_TARGET_ARM) #elif defined(UNW_TARGET_ARM)
if (regnum < 0 || regnum >= 16) if (regnum >= 16)
goto badreg; goto badreg;
#elif defined(UNW_TARGET_SH) #elif defined(UNW_TARGET_SH)
if (regnum < 0 || regnum > UNW_SH_PR) if (regnum > UNW_SH_PR)
goto badreg; goto badreg;
#elif defined(UNW_TARGET_TILEGX) #elif defined(UNW_TARGET_TILEGX)
if (regnum < 0 || regnum > UNW_TILEGX_CFA) if (regnum > UNW_TILEGX_CFA)
goto badreg; goto badreg;
#else #else
#if defined(UNW_TARGET_MIPS) #if defined(UNW_TARGET_MIPS)
@ -120,7 +123,7 @@ _UCD_access_reg (unw_addr_space_t as,
#error Port me #error Port me
#endif #endif
if (regnum < 0 || regnum >= (unw_regnum_t)ARRAY_SIZE(remap_regs)) if (regnum >= (unw_regnum_t)ARRAY_SIZE(remap_regs))
goto badreg; goto badreg;
regnum = remap_regs[regnum]; regnum = remap_regs[regnum];