m2-internship/libunwind-eh_elf
1
0
Fork 0
mirror of https://github.com/tobast/libunwind-eh_elf.git synced 2025-01-11 03:23:43 +01:00
Code Issues Releases Activity

Dwarf cache nodes are allocated in a round-robin fashion, despite the

Browse source 
'lru' prefix used in several data fields.  Drop the unnecessary fields,
and just use a simple counter to track the next cache entry to be recycled.
This commit is contained in:
Doug Moore 2017-06-14 16:27:24 -05:00 committed by Dave Watson
parent 5c0e619f84
commit 0b51f5892d
2 changed files with 4 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
include/dwarf.h
View file

@ -273,7 +273,6 @@ dwarf_stackable_reg_state_t;
typedef struct dwarf_reg_cache_entry typedef struct dwarf_reg_cache_entry
{ {
unw_word_t ip; /* ip this rs is for */ unw_word_t ip; /* ip this rs is for */
unsigned short lru_chain; /* used for least-recently-used chain */
unsigned short coll_chain; /* used for hash collisions */ unsigned short coll_chain; /* used for hash collisions */
unsigned short hint; /* hint for next rs to try (or -1) */ unsigned short hint; /* hint for next rs to try (or -1) */
unsigned short valid : 1; /* optional machine-dependent signal info */ unsigned short valid : 1; /* optional machine-dependent signal info */
@ -346,8 +345,7 @@ typedef unsigned char unw_hash_index_t;
struct dwarf_rs_cache struct dwarf_rs_cache
{ {
pthread_mutex_t lock; pthread_mutex_t lock;
unsigned short lru_head; /* index of lead-recently used rs */ unsigned short rr_head; /* index of least-recently allocated rs */
unsigned short lru_tail; /* index of most-recently used rs */
unsigned short log_size; unsigned short log_size;
unsigned short prev_log_size; unsigned short prev_log_size;

13
src/dwarf/Gparser.c
View file

@ -583,13 +583,10 @@ dwarf_flush_rs_cache (struct dwarf_rs_cache *cache)
cache->prev_log_size = cache->log_size; cache->prev_log_size = cache->log_size;
} }
cache->lru_head = DWARF_UNW_CACHE_SIZE(cache->log_size) - 1; cache->rr_head = 0;
cache->lru_tail = 0;
for (i = 0; i < DWARF_UNW_CACHE_SIZE(cache->log_size); ++i) for (i = 0; i < DWARF_UNW_CACHE_SIZE(cache->log_size); ++i)
{ {
if (i > 0)
cache->links[i].lru_chain = (i - 1);
cache->links[i].coll_chain = -1; cache->links[i].coll_chain = -1;
cache->links[i].ip = 0; cache->links[i].ip = 0;
cache->links[i].valid = 0; cache->links[i].valid = 0;
@ -681,12 +678,8 @@ rs_new (struct dwarf_rs_cache *cache, struct dwarf_cursor * c)
unw_hash_index_t index; unw_hash_index_t index;
unsigned short head; unsigned short head;
head = cache->lru_head; head = cache->rr_head;
cache->lru_head = cache->links[head].lru_chain; cache->rr_head = (head + 1) & (cache->log_size - 1);
/* re-insert rs at the tail of the LRU chain: */
cache->links[cache->lru_tail].lru_chain = head;
cache->lru_tail = head;
/* remove the old rs from the hash table (if it's there): */ /* remove the old rs from the hash table (if it's there): */
if (cache->links[head].ip) if (cache->links[head].ip)