From 0f706c37fe2344bb2dca20fcb48972342776459e Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Lorenz=20H=C3=BCbschle-Schneider?=
 <lorenz-dev@lgh-alumni.de>
Date: Thu, 21 May 2015 21:08:17 +0200
Subject: [PATCH] settings: add a cache

From the comment:
This cache is important for two reasons. One, angular hits it up really often
(because it needs to check for changes and it's not very clever about it).
Two, it prevents weird type conversion issues that otherwise arise in
$store.parseValue (e.g. converting "123." to the number 123 even though it
actually was the beginning of an IP address that the user was in the
process of entering).
---
 js/settings.js | 13 ++++++++++++-
 1 file changed, 12 insertions(+), 1 deletion(-)

diff --git a/js/settings.js b/js/settings.js
index b153d1a..4e19ec9 100644
--- a/js/settings.js
+++ b/js/settings.js
@@ -6,6 +6,13 @@ var weechat = angular.module('weechat');
 weechat.factory('settings', ['$store', '$rootScope', function($store, $rootScope) {
 	var that = this;
 	this.callbacks = {};
+	// This cache is important for two reasons. One, angular hits it up really often
+	// (because it needs to check for changes and it's not very clever about it).
+	// Two, it prevents weird type conversion issues that otherwise arise in
+	// $store.parseValue (e.g. converting "123." to the number 123 even though it
+	// actually was the beginning of an IP address that the user was in the
+	// process of entering)
+	this.cache = {};
 
 	// Define a property for a setting, retrieving it on read
 	// and writing it to localStorage on write
@@ -14,9 +21,13 @@ weechat.factory('settings', ['$store', '$rootScope', function($store, $rootScope
 			enumerable: true,
 			key: key,
 			get: function() {
-				return $store.get(key);
+				if (!(key in this.cache)) {
+					this.cache[key] = $store.get(key);
+				}
+				return this.cache[key];
 			},
 			set: function(newVal) {
+				this.cache[key] = newVal;
 				$store.set(key, newVal);
 				// Call any callbacks
 				var callbacks = that.callbacks[key];