16c00db4bb
Pull AFS fixes from David Howells:
"Here's a set of patches that fix a number of bugs in the in-kernel AFS
client, including:
- Fix directory locking to not use individual page locks for
directory reading/scanning but rather to use a semaphore on the
afs_vnode struct as the directory contents must be read in a single
blob and data from different reads must not be mixed as the entire
contents may be shuffled about between reads.
- Fix address list parsing to handle port specifiers correctly.
- Only give up callback records on a server if we actually talked to
that server (we might not be able to access a server).
- Fix some callback handling bugs, including refcounting,
whole-volume callbacks and when callbacks actually get broken in
response to a CB.CallBack op.
- Fix some server/address rotation bugs, including giving up if we
can't probe a server; giving up if a server says it doesn't have a
volume, but there are more servers to try.
- Fix the decoding of fetched statuses to be OpenAFS compatible.
- Fix the handling of server lookups in Cache Manager ops (such as
CB.InitCallBackState3) to use a UUID if possible and to handle no
server being found.
- Fix a bug in server lookup where not all addresses are compared.
- Fix the non-encryption of calls that prevents some servers from
being accessed (this also requires an AF_RXRPC patch that has
already gone in through the net tree).
There's also a patch that adds tracepoints to log Cache Manager ops
that don't find a matching server, either by UUID or by address"
* tag 'afs-fixes-20180514' of git://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs:
afs: Fix the non-encryption of calls
afs: Fix CB.CallBack handling
afs: Fix whole-volume callback handling
afs: Fix afs_find_server search loop
afs: Fix the handling of an unfound server in CM operations
afs: Add a tracepoint to record callbacks from unlisted servers
afs: Fix the handling of CB.InitCallBackState3 to find the server by UUID
afs: Fix VNOVOL handling in address rotation
afs: Fix AFSFetchStatus decoder to provide OpenAFS compatibility
afs: Fix server rotation's handling of fileserver probe failure
afs: Fix refcounting in callback registration
afs: Fix giving up callbacks on server destruction
afs: Fix address list parsing
afs: Fix directory page locking
140 lines
3.7 KiB
C
140 lines
3.7 KiB
C
// SPDX-License-Identifier: GPL-2.0
|
|
#include <stdlib.h>
|
|
#include <sys/types.h>
|
|
#include <unistd.h>
|
|
#include <sys/prctl.h>
|
|
#include "tests.h"
|
|
#include "thread_map.h"
|
|
#include "debug.h"
|
|
|
|
#define NAME (const char *) "perf"
|
|
#define NAMEUL (unsigned long) NAME
|
|
|
|
int test__thread_map(struct test *test __maybe_unused, int subtest __maybe_unused)
|
|
{
|
|
struct thread_map *map;
|
|
|
|
TEST_ASSERT_VAL("failed to set process name",
|
|
!prctl(PR_SET_NAME, NAMEUL, 0, 0, 0));
|
|
|
|
/* test map on current pid */
|
|
map = thread_map__new_by_pid(getpid());
|
|
TEST_ASSERT_VAL("failed to alloc map", map);
|
|
|
|
thread_map__read_comms(map);
|
|
|
|
TEST_ASSERT_VAL("wrong nr", map->nr == 1);
|
|
TEST_ASSERT_VAL("wrong pid",
|
|
thread_map__pid(map, 0) == getpid());
|
|
TEST_ASSERT_VAL("wrong comm",
|
|
thread_map__comm(map, 0) &&
|
|
!strcmp(thread_map__comm(map, 0), NAME));
|
|
TEST_ASSERT_VAL("wrong refcnt",
|
|
refcount_read(&map->refcnt) == 1);
|
|
thread_map__put(map);
|
|
|
|
/* test dummy pid */
|
|
map = thread_map__new_dummy();
|
|
TEST_ASSERT_VAL("failed to alloc map", map);
|
|
|
|
thread_map__read_comms(map);
|
|
|
|
TEST_ASSERT_VAL("wrong nr", map->nr == 1);
|
|
TEST_ASSERT_VAL("wrong pid", thread_map__pid(map, 0) == -1);
|
|
TEST_ASSERT_VAL("wrong comm",
|
|
thread_map__comm(map, 0) &&
|
|
!strcmp(thread_map__comm(map, 0), "dummy"));
|
|
TEST_ASSERT_VAL("wrong refcnt",
|
|
refcount_read(&map->refcnt) == 1);
|
|
thread_map__put(map);
|
|
return 0;
|
|
}
|
|
|
|
static int process_event(struct perf_tool *tool __maybe_unused,
|
|
union perf_event *event,
|
|
struct perf_sample *sample __maybe_unused,
|
|
struct machine *machine __maybe_unused)
|
|
{
|
|
struct thread_map_event *map = &event->thread_map;
|
|
struct thread_map *threads;
|
|
|
|
TEST_ASSERT_VAL("wrong nr", map->nr == 1);
|
|
TEST_ASSERT_VAL("wrong pid", map->entries[0].pid == (u64) getpid());
|
|
TEST_ASSERT_VAL("wrong comm", !strcmp(map->entries[0].comm, NAME));
|
|
|
|
threads = thread_map__new_event(&event->thread_map);
|
|
TEST_ASSERT_VAL("failed to alloc map", threads);
|
|
|
|
TEST_ASSERT_VAL("wrong nr", threads->nr == 1);
|
|
TEST_ASSERT_VAL("wrong pid",
|
|
thread_map__pid(threads, 0) == getpid());
|
|
TEST_ASSERT_VAL("wrong comm",
|
|
thread_map__comm(threads, 0) &&
|
|
!strcmp(thread_map__comm(threads, 0), NAME));
|
|
TEST_ASSERT_VAL("wrong refcnt",
|
|
refcount_read(&threads->refcnt) == 1);
|
|
thread_map__put(threads);
|
|
return 0;
|
|
}
|
|
|
|
int test__thread_map_synthesize(struct test *test __maybe_unused, int subtest __maybe_unused)
|
|
{
|
|
struct thread_map *threads;
|
|
|
|
TEST_ASSERT_VAL("failed to set process name",
|
|
!prctl(PR_SET_NAME, NAMEUL, 0, 0, 0));
|
|
|
|
/* test map on current pid */
|
|
threads = thread_map__new_by_pid(getpid());
|
|
TEST_ASSERT_VAL("failed to alloc map", threads);
|
|
|
|
thread_map__read_comms(threads);
|
|
|
|
TEST_ASSERT_VAL("failed to synthesize map",
|
|
!perf_event__synthesize_thread_map2(NULL, threads, process_event, NULL));
|
|
|
|
return 0;
|
|
}
|
|
|
|
int test__thread_map_remove(struct test *test __maybe_unused, int subtest __maybe_unused)
|
|
{
|
|
struct thread_map *threads;
|
|
char *str;
|
|
int i;
|
|
|
|
TEST_ASSERT_VAL("failed to allocate map string",
|
|
asprintf(&str, "%d,%d", getpid(), getppid()) >= 0);
|
|
|
|
threads = thread_map__new_str(str, NULL, 0, false);
|
|
|
|
TEST_ASSERT_VAL("failed to allocate thread_map",
|
|
threads);
|
|
|
|
if (verbose > 0)
|
|
thread_map__fprintf(threads, stderr);
|
|
|
|
TEST_ASSERT_VAL("failed to remove thread",
|
|
!thread_map__remove(threads, 0));
|
|
|
|
TEST_ASSERT_VAL("thread_map count != 1", threads->nr == 1);
|
|
|
|
if (verbose > 0)
|
|
thread_map__fprintf(threads, stderr);
|
|
|
|
TEST_ASSERT_VAL("failed to remove thread",
|
|
!thread_map__remove(threads, 0));
|
|
|
|
TEST_ASSERT_VAL("thread_map count != 0", threads->nr == 0);
|
|
|
|
if (verbose > 0)
|
|
thread_map__fprintf(threads, stderr);
|
|
|
|
TEST_ASSERT_VAL("failed to not remove thread",
|
|
thread_map__remove(threads, 0));
|
|
|
|
for (i = 0; i < threads->nr; i++)
|
|
free(threads->map[i].comm);
|
|
|
|
free(threads);
|
|
return 0;
|
|
}
|