1
0
Fork 0
mirror of https://github.com/tobast/libunwind-eh_elf.git synced 2024-09-27 17:09:29 +02:00
libunwind-eh_elf/src
Paul Pluzhnikov 1bca6eb8ea Remove unnecessary calls to labs()
We've just traced a large memory increase to that patch (Google ref:
b/18069427).
It appears that labs() was there for a good reason.

Sorry about that :-(

For the curious:

  unsigned long u1 = ~0UL;
  unsigned long u2 = labs(u1);

  assert(u1 != u2);  // labs on unsigned *may* have an effect, despite
what Clang says.

Attached patch suppresses the Clang warning, while still keeping the
original behavior (which I believe to be correct).

Thanks,
--
Paul Pluzhnikov
2014-10-24 22:29:15 -07:00
..
aarch64 One time whitespace fixup. 2014-09-27 09:47:23 -07:00
arm One time whitespace fixup. 2014-09-27 09:47:23 -07:00
coredump One time whitespace fixup. 2014-09-27 09:47:23 -07:00
dwarf One time whitespace fixup. 2014-09-27 09:47:23 -07:00
hppa One time whitespace fixup. 2014-09-27 09:47:23 -07:00
ia64 One time whitespace fixup. 2014-09-27 09:47:23 -07:00
mi One time whitespace fixup. 2014-09-27 09:47:23 -07:00
mips One time whitespace fixup. 2014-09-27 09:47:23 -07:00
ppc One time whitespace fixup. 2014-09-27 09:47:23 -07:00
ppc32 One time whitespace fixup. 2014-09-27 09:47:23 -07:00
ppc64 One time whitespace fixup. 2014-09-27 09:47:23 -07:00
ptrace One time whitespace fixup. 2014-09-27 09:47:23 -07:00
setjmp One time whitespace fixup. 2014-09-27 09:47:23 -07:00
sh One time whitespace fixup. 2014-09-27 09:47:23 -07:00
tilegx Add TileGx platform support to libunwind. 2014-09-08 16:21:53 -04:00
unwind One time whitespace fixup. 2014-09-27 09:47:23 -07:00
x86 One time whitespace fixup. 2014-09-27 09:47:23 -07:00
x86_64 Remove unnecessary calls to labs() 2014-10-24 22:29:15 -07:00
elf32.c Do nothing of UNW_REMOTE_ONLY is defined. 2003-02-15 03:10:30 +00:00
elf32.h One time whitespace fixup. 2014-09-27 09:47:23 -07:00
elf64.c Do nothing of UNW_REMOTE_ONLY is defined. 2003-02-15 03:10:30 +00:00
elf64.h One time whitespace fixup. 2014-09-27 09:47:23 -07:00
elfxx.c One time whitespace fixup. 2014-09-27 09:47:23 -07:00
elfxx.h One time whitespace fixup. 2014-09-27 09:47:23 -07:00
libunwind-generic.pc.in Add Cflags keyword to pkg-config metadata files 2013-08-26 05:40:19 -07:00
Makefile.am Merge branch 'fast-stack-trace-arm' of https://github.com/fillexen/libunwind 2014-09-20 08:09:55 -07:00
os-freebsd.c One time whitespace fixup. 2014-09-27 09:47:23 -07:00
os-hpux.c One time whitespace fixup. 2014-09-27 09:47:23 -07:00
os-linux.c One time whitespace fixup. 2014-09-27 09:47:23 -07:00
os-linux.h One time whitespace fixup. 2014-09-27 09:47:23 -07:00
os-qnx.c One time whitespace fixup. 2014-09-27 09:47:23 -07:00